fix(ci): Use $ROOT/dist for wheel distribution#2506
Merged
Conversation
* Update deploy.sh to use the $ROOT/dist path for storing wheels. * This change ensures consistent wheel distribution across different platforms. * Fixes an issue where wheels were being placed in relative ../dist directories. Fixes apache#2505
chaokunyang
approved these changes
Aug 24, 2025
Collaborator
|
@pandalee99 Please cherry-pick this PR to releases-0.12 for v0.12.1 release |
Contributor
Author
|
No don't I'm not ready |
Contributor
Author
|
Sorry I was just about to mark it as draft |
Contributor
Author
|
Actually I think it might work as is; could you release? |
Collaborator
cc @pandalee99 |
chaokunyang
pushed a commit
that referenced
this pull request
Aug 25, 2025
## Why The python wheels were not being found. ## What does this PR do? * Update deploy.sh to use the $ROOT/dist path for storing wheels. * This change ensures consistent wheel distribution across different platforms. * Fixes an issue where wheels were being placed in relative ../dist directories. ## Related issues Fixes #2505
Collaborator
|
@esafak Seems still doesn't work: |
Contributor
Author
|
The Windows wheels fail to build because I neglected to specify the bash shell, as you noticed. #2511 |
chaokunyang
pushed a commit
that referenced
this pull request
Aug 25, 2025
## Why? * Wheels were not created on Windows because it does not use bash by default * Once that works, downloading them will fail because `actions/download-artifact` requires the `run-id` to access artifacts from different workflows. ## What does this PR do? * Add `actions: read` permission to release workflow. * Configure `download-artifact` action to use `run-id` and `pattern` for downloading wheels from a previous workflow run. * Enable `merge-multiple` for downloading artifacts. * Add `shell: bash` to build step in native release workflow. ## Related issues #2506
chaokunyang
pushed a commit
that referenced
this pull request
Aug 25, 2025
## Why? * Wheels were not created on Windows because it does not use bash by default * Once that works, downloading them will fail because `actions/download-artifact` requires the `run-id` to access artifacts from different workflows. ## What does this PR do? * Add `actions: read` permission to release workflow. * Configure `download-artifact` action to use `run-id` and `pattern` for downloading wheels from a previous workflow run. * Enable `merge-multiple` for downloading artifacts. * Add `shell: bash` to build step in native release workflow. ## Related issues #2506
chaokunyang
pushed a commit
that referenced
this pull request
Aug 27, 2025
## Why The python wheels were not being found. ## What does this PR do? * Update deploy.sh to use the $ROOT/dist path for storing wheels. * This change ensures consistent wheel distribution across different platforms. * Fixes an issue where wheels were being placed in relative ../dist directories. ## Related issues Fixes #2505
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The python wheels were not being found.
What does this PR do?
Related issues
Fixes #2505