fix(python): fix publich tag for workflow#2517
Merged
Merged
Conversation
chaokunyang
force-pushed
the
fix_publish_tag
branch
from
5e582bf to
f299445
Compare
chaokunyang
requested review from
LiangliangSui,
Copilot,
pandalee99 and
theweipeng
pandalee99
approved these changes
Aug 25, 2025
chaokunyang
added a commit
to chaokunyang/fory
that referenced
this pull request
Aug 25, 2025
<!-- **Thanks for contributing to Fory.** **If this is your first time opening a PR on fory, you can refer to [CONTRIBUTING.md](https://github.com/apache/fory/blob/main/CONTRIBUTING.md).** Contribution Checklist - The **Apache Fory** community has requirements on the naming of pr titles. You can also find instructions in [CONTRIBUTING.md](https://github.com/apache/fory/blob/main/CONTRIBUTING.md). - Fory has a strong focus on performance. If the PR you submit will have an impact on performance, please benchmark it first and provide the benchmark result here. --> ## Why? In a workflow_run event GitHub gives the Publish workflow a brand-new run context. The variables in that context describe this run, not the upstream one. Unless you push the tag again while the Publish workflow is running, the new context will not contain that tag: github.ref → refs/heads/main (or whatever the default branch is) github.ref_name → main github.ref_type → branch <!-- Describe the purpose of this PR. --> ## What does this PR do? Use the payload that GitHub attaches to the workflow_run event: github.event.workflow_run.head_branch # the tag (or branch) that the upstream workflow ran for github.event.workflow_run.head_sha # the commit SHA These are the values that correspond to the tag push. ## Related issues Closes apache#2515 ## Does this PR introduce any user-facing change? <!-- If any user-facing interface changes, please [open an issue](https://github.com/apache/fory/issues/new/choose) describing the need to do so and update the document if necessary. Delete section if not applicable. --> - [ ] Does this PR introduce any public API change? - [ ] Does this PR introduce any binary protocol compatibility change? ## Benchmark <!-- When the PR has an impact on performance (if you don't know whether the PR will have an impact on performance, you can submit the PR first, and if it will have impact on performance, the code reviewer will explain it), be sure to attach a benchmark data here. Delete section if not applicable. -->
chaokunyang
added a commit
that referenced
this pull request
Aug 27, 2025
<!-- **Thanks for contributing to Fory.** **If this is your first time opening a PR on fory, you can refer to [CONTRIBUTING.md](https://github.com/apache/fory/blob/main/CONTRIBUTING.md).** Contribution Checklist - The **Apache Fory** community has requirements on the naming of pr titles. You can also find instructions in [CONTRIBUTING.md](https://github.com/apache/fory/blob/main/CONTRIBUTING.md). - Fory has a strong focus on performance. If the PR you submit will have an impact on performance, please benchmark it first and provide the benchmark result here. --> ## Why? In a workflow_run event GitHub gives the Publish workflow a brand-new run context. The variables in that context describe this run, not the upstream one. Unless you push the tag again while the Publish workflow is running, the new context will not contain that tag: github.ref → refs/heads/main (or whatever the default branch is) github.ref_name → main github.ref_type → branch <!-- Describe the purpose of this PR. --> ## What does this PR do? Use the payload that GitHub attaches to the workflow_run event: github.event.workflow_run.head_branch # the tag (or branch) that the upstream workflow ran for github.event.workflow_run.head_sha # the commit SHA These are the values that correspond to the tag push. ## Related issues Closes #2515 ## Does this PR introduce any user-facing change? <!-- If any user-facing interface changes, please [open an issue](https://github.com/apache/fory/issues/new/choose) describing the need to do so and update the document if necessary. Delete section if not applicable. --> - [ ] Does this PR introduce any public API change? - [ ] Does this PR introduce any binary protocol compatibility change? ## Benchmark <!-- When the PR has an impact on performance (if you don't know whether the PR will have an impact on performance, you can submit the PR first, and if it will have impact on performance, the code reviewer will explain it), be sure to attach a benchmark data here. Delete section if not applicable. -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
In a workflow_run event GitHub gives the Publish workflow a brand-new run context.
The variables in that context describe this run, not the upstream one.
Unless you push the tag again while the Publish workflow is running, the new context will not contain that tag:
github.ref → refs/heads/main (or whatever the default branch is)
github.ref_name → main
github.ref_type → branch
What does this PR do?
Use the payload that GitHub attaches to the workflow_run event:
github.event.workflow_run.head_branch # the tag (or branch) that the upstream workflow ran for
github.event.workflow_run.head_sha # the commit SHA
These are the values that correspond to the tag push.
Related issues
Closes #2515
Does this PR introduce any user-facing change?
Benchmark