-
Notifications
You must be signed in to change notification settings - Fork 409
feat(compiler): Add JavaScript/TypeScript IDL code generation #3394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
chaokunyang
merged 70 commits into
apache:main
from
miantalha45:generate-messageTypes-from-IDL
Apr 14, 2026
Merged
Changes from all commits
Commits
Show all changes
70 commits
Select commit
Hold shift + click to select a range
4cecf83
feat(compiler): Add JavaScript/TypeScript IDL code generation for gRPC
miantalha45 42c840c
Fix linting issues
miantalha45 1cf6e76
chore: remove incorrect JavaScript codegen files
miantalha45 7d92cb2
feat(compiler): add TypeScript/JavaScript code generation
miantalha45 6dc214d
Pushing remaining changes
miantalha45 918f762
Fix linting issues
miantalha45 4fe3d0b
docs: improve TypeScript generator docstring
miantalha45 92cd483
fix(compiler): address Copilot code review comments on TypeScript gen…
miantalha45 361b2b6
Fix code generation for JS/TS
miantalha45 362eb44
Merge branch 'main' into generate-messageTypes-from-IDL
miantalha45 b33168b
Fix failing checks
miantalha45 8833cb1
Fix linting issues
miantalha45 3488282
Fix linting issue
miantalha45 469b122
chore(typescript): remove package-lock.json from tracking and add .gi…
miantalha45 a7f9b4e
Merge branch 'main' into generate-messageTypes-from-IDL
miantalha45 7fc0e87
ci(javascript): add TypeScript IDL tests to javascript_xlang CI job
miantalha45 61539b6
chore: apply formatter fixes (prettier, ruff)
miantalha45 eaf01c8
fix(typescript): align run_typescript_tests.sh with other language ID…
miantalha45 749889b
chore: trigger CI recheck
miantalha45 3abc1de
Addressing all comments from reviewer
miantalha45 75c679b
Fix failing checks
miantalha45 6d9a656
chore: trigger PR reprocessing
miantalha45 b2bfd69
fix(docs): fix mismatched code fence in generated-code.md
miantalha45 a4570bd
chore: trigger PR reprocessing
miantalha45 0368926
Rename TS to JS
miantalha45 7d4ba20
style: wrap long line in test_javascript_codegen.py
miantalha45 4472a21
Fix all changes told in comments
miantalha45 cd6d54d
Merge branch 'main' into generate-messageTypes-from-IDL
chaokunyang 449eaee
One failing tests fixed
miantalha45 c235ec6
Add new renamed imports
miantalha45 11bbea6
Fix failing tests
miantalha45 41859bc
Merge branch 'main' into generate-messageTypes-from-IDL
miantalha45 82e1212
Merge branch 'main' into generate-messageTypes-from-IDL
miantalha45 3bda7c4
Fix failing xlang tests
miantalha45 e9d5066
Merge branch 'main' into generate-messageTypes-from-IDL
miantalha45 8099090
Updated tests for compatible format
miantalha45 421cec7
Fix failing CI checks
miantalha45 e5c0f42
Merge branch 'main' into generate-messageTypes-from-IDL
miantalha45 f611010
Fix xlang tests
miantalha45 25753ab
Revert "Fix xlang tests"
miantalha45 419ad85
Fix naming conventions for JS
miantalha45 2316a5e
Fix js compiler test naming conventions
miantalha45 19f7785
Fix naming conventions for nested structs/enums
miantalha45 e78140d
Fix formatting
miantalha45 3fa17e9
PascalCase for class names in JS
miantalha45 1681189
Fix failing test
miantalha45 66cb436
fix failing idl tests
miantalha45 2c6d901
trigger CI
miantalha45 dfa843b
Merge branch 'main' into generate-messageTypes-from-IDL
miantalha45 d4fdff3
Fix copilot suggestions
miantalha45 bec6ee6
Merge branch 'main' into generate-messageTypes-from-IDL
miantalha45 7fc4c64
Merge branch 'main' into generate-messageTypes-from-IDL
miantalha45 d839521
Add union support in JS generator
miantalha45 23ea5cc
Fix code style
miantalha45 4d22f45
fix the comments
miantalha45 f121c6b
fix comments
miantalha45 64e4c6a
Some enhancements
miantalha45 14526d6
some fixes
miantalha45 990671a
trigger CI
miantalha45 0dcb2f8
address AI Review
miantalha45 7157506
Merge branch 'main' into generate-messageTypes-from-IDL
miantalha45 b1699b6
trigger CI
miantalha45 6558a01
trigger CI
miantalha45 a5477b1
Fix offset issue from collection.ts file
miantalha45 6f10ab9
fixes
miantalha45 f36f49a
Merge branch 'main' into generate-messageTypes-from-IDL
miantalha45 36164aa
Fix failing CI
miantalha45 0b996a3
Merge branch 'main' into generate-messageTypes-from-IDL
miantalha45 28ca89a
Fix code style
miantalha45 24481f9
Change refTracking to ref
miantalha45 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR description references a new
compiler/fory_compiler/generators/typescript.pyand aTypeScriptGenerator, but the implementation added in this PR iscompiler/fory_compiler/generators/javascript.pywithJavaScriptGeneratorregistered under thejavascriptlanguage. Please update the PR description (or naming) to match the actual generator/module names to avoid confusion for reviewers and users.