Fix JMXDataUpdater code formatting and structure

Fixed malformed code from previous commit:
- Moved success-path logging to correct location
- Moved failure-path logging to catch block properly
- Removed corrupted text fragment
- Applied spotless formatting

Author: JinwooHwang

geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/data/JMXDataUpdater.java

@@ -176,7 +176,8 @@ public JMXConnector connect(Object credentials) {
     long connectStartTime = System.currentTimeMillis();
     System.err.println("[JMX-CONNECT] Starting JMX connection at " + java.time.Instant.now());
     System.err.println("[JMX-CONNECT] Thread: " + Thread.currentThread().getName());
-    System.err.println("[JMX-CONNECT] Credentials type: " + (credentials != null ? credentials.getClass().getName() : "null"));
+    System.err.println("[JMX-CONNECT] Credentials type: "
+        + (credentials != null ? credentials.getClass().getName() : "null"));
     try {
 
       String jmxSerURL = "";
@@ -224,33 +225,38 @@ public JMXConnector connect(Object credentials) {
             env.put("com.sun.jndi.rmi.factory.socket", new SslRMIClientSocketFactory());
           }
           logger.info("Connecting to jmxURL : {}", jmxSerURL);
-          System.err.println("[JMX-CONNECT] Attempting JMXConnectorFactory.connect() to: " + jmxSerURL);
+          System.err
+              .println("[JMX-CONNECT] Attempting JMXConnectorFactory.connect() to: " + jmxSerURL);
           System.err.println("[JMX-CONNECT] With SSL: " + repository.isUseSSLManager());
           long jmxCallStart = System.currentTimeMillis();
           conn = JMXConnectorFactory.connect(url, env);
           long jmxCallEnd = System.currentTimeMillis();
-          System.err.println("[JMX-CONNECT] JMXConnectorFactory.connect() successful in " + (jmxCallEnd - jmxCallStart) + "ms");
+          System.err.println("[JMX-CONNECT] JMXConnectorFactory.connect() successful in "
+              + (jmxCallEnd - jmxCallStart) + "ms");
           mbs = conn.getMBeanServerConnection();
           cluster.setConnectedFlag(true);
+          long totalDuration = System.currentTimeMillis() - connectStartTime;
+          System.err.println("[JMX-CONNECT] Total connection time: " + totalDuration + "ms");
+        } finally {
+          System.setProperties(originalProperties);
+        }
+      }
+    } catch (Exception e) {
       long totalDuration = System.currentTimeMillis() - connectStartTime;
       cluster.setConnectedFlag(false);
       cluster.setConnectionErrorMsg(e.getMessage());
       System.err.println("[JMX-CONNECT] Connection FAILED after " + totalDuration + "ms");
       System.err.println("[JMX-CONNECT] Exception type: " + e.getClass().getName());
       System.err.println("[JMX-CONNECT] Exception message: " + e.getMessage());
       if (e.getCause() != null) {
-        System.err.println("[JMX-CONNECT] Caused by: " + e.getCause().getClass().getName() + ": " + e.getCause().getMessage());
+        System.err.println("[JMX-CONNECT] Caused by: " + e.getCause().getClass().getName() + ": "
+            + e.getCause().getMessage());
         if (e.getCause().getCause() != null) {
-          System.err.println("[JMX-CONNECT]   Caused by: " + e.getCause().getCause().getClass().getName() + ": " + e.getCause().getCause().getMessage());
-        }
-      }nnection time: " + totalDuration + "ms");
-        } finally {
-          System.setProperties(originalProperties);
+          System.err
+              .println("[JMX-CONNECT]   Caused by: " + e.getCause().getCause().getClass().getName()
+                  + ": " + e.getCause().getCause().getMessage());
         }
       }
-    } catch (Exception e) {
-      cluster.setConnectedFlag(false);
-      cluster.setConnectionErrorMsg(e.getMessage());
       logger.fatal(e.getMessage(), e);
       if (conn != null) {
         try {

geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/security/GemFireAuthenticationProvider.java

@@ -63,19 +63,24 @@ public Authentication authenticate(Authentication authentication) throws Authent
     String password = authentication.getCredentials().toString();
 
     logger.debug("Connecting to GemFire with user=" + name);
-    System.err.println("[PULSE-AUTH] Authentication request for user: " + name + " at " + java.time.Instant.now());
+    System.err.println(
+        "[PULSE-AUTH] Authentication request for user: " + name + " at " + java.time.Instant.now());
     long authStartTime = System.currentTimeMillis();
     Cluster cluster = repository.getClusterWithUserNameAndPassword(name, password);
     long authEndTime = System.currentTimeMillis();
-    System.err.println("[PULSE-AUTH] getClusterWithUserNameAndPassword returned in " + (authEndTime - authStartTime) + "ms");
-    System.err.println("[PULSE-AUTH] Cluster connected flag: " + (cluster != null && cluster.isConnectedFlag()));
-    System.err.println("[PULSE-AUTH] Cluster connection error: " + (cluster != null ? cluster.getConnectionErrorMsg() : "null"));
+    System.err.println("[PULSE-AUTH] getClusterWithUserNameAndPassword returned in "
+        + (authEndTime - authStartTime) + "ms");
+    System.err.println(
+        "[PULSE-AUTH] Cluster connected flag: " + (cluster != null && cluster.isConnectedFlag()));
+    System.err.println("[PULSE-AUTH] Cluster connection error: "
+        + (cluster != null ? cluster.getConnectionErrorMsg() : "null"));
     JMXConnector jmxc = cluster != null ? cluster.getJMXConnector() : null;
     if (jmxc == null) {
       System.err.println("[PULSE-AUTH] JMXConnector is NULL - authentication FAILED for " + name);
       throw new BadCredentialsException("Error connecting to GemFire JMX Server");
     }
-    System.err.println("[PULSE-AUTH] JMXConnector obtained - authentication SUCCESSFUL for " + name);
+    System.err
+        .println("[PULSE-AUTH] JMXConnector obtained - authentication SUCCESSFUL for " + name);
 
     Collection<GrantedAuthority> list = GemFireAuthentication.populateAuthorities(jmxc);
     GemFireAuthentication auth = new GemFireAuthentication(authentication.getPrincipal(),