Skip to content

GEODE-10481: Proposal & Todo#7937

Merged
sboorlagadda merged 2 commits into
developfrom
feature/GEODE-10481-proposal-change
Sep 28, 2025
Merged

GEODE-10481: Proposal & Todo#7937
sboorlagadda merged 2 commits into
developfrom
feature/GEODE-10481-proposal-change

Conversation

@sboorlagadda

@sboorlagadda sboorlagadda commented Sep 28, 2025

Copy link
Copy Markdown
Member

This PR brings in an reviewed proposal and a todo to track the progress.

Earlier PR merged the markdown files into the root folder, this PR moved
them into a proposals folder so that the community can track the plan
and progress.

For all changes, please confirm:

  • Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
  • Has your PR been rebased against the latest commit within the target branch (typically develop)?
  • Is your initial contribution a single, squashed commit?
  • Does gradlew build run cleanly?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

@sboorlagadda

Copy link
Copy Markdown
Member Author

@JinwooHwang Thanks for merging the #7933 but I wanted to revise the proposal with our discussion and also move them into a proposals folder. It also has a todo.md to keep track of the progress.

@JinwooHwang

JinwooHwang commented Sep 28, 2025

Copy link
Copy Markdown
Contributor

Hi @sboorlagadda, I apologize for merging it without realizing your intention. Please feel free to clean up the mess I created. I am so sorry.
I’m still getting familiar with our merge process and wanted to ask for your advice. Who usually handles the merge, and when is it typically done? I’d really appreciate your guidance as I continue learning. Thanks again!

@sboorlagadda

Copy link
Copy Markdown
Member Author

Hi @sboorlagadda, I apologize for merging it without realizing your intention. Please feel free to clean up the mess I created. I am so sorry. I’m still getting familiar with our merge process and wanted to ask for your advice. Who usually handles the merge, and when is it typically done? I’d really appreciate your guidance as I continue learning. Thanks again!

It's alright. This pr already does cleanup and if you approve I can merge it. Usually what works great is having the developer proposing the changes merge, that way they can do final cleanup, rebase etc before merging.

So if you can approve this change I will merge

@JinwooHwang

Copy link
Copy Markdown
Contributor

Hi @sboorlagadda . Appreciate the initiative and cleanup already in place. Approved—please go ahead and merge when ready. Let me know if anything else needs attention.

@JinwooHwang JinwooHwang left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@sboorlagadda sboorlagadda merged commit 2699a03 into develop Sep 28, 2025
17 checks passed
@sboorlagadda sboorlagadda deleted the feature/GEODE-10481-proposal-change branch September 28, 2025 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants