Skip to content

Commit 6270b01

Browse files
committed
[GLUTEN-12157][VL] Drop ln registration — prestosql::LnFunction has different null semantics
1 parent 6568862 commit 6270b01

2 files changed

Lines changed: 0 additions & 7 deletions

File tree

backends-velox/src/test/scala/org/apache/gluten/functions/MathFunctionsValidateSuite.scala

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -256,12 +256,6 @@ class MathFunctionsValidateSuite extends FunctionsValidateSuite {
256256
}
257257
}
258258

259-
test("ln") {
260-
runQueryAndCompare("SELECT ln(l_orderkey) from lineitem limit 1") {
261-
checkGlutenPlan[ProjectExecTransformer]
262-
}
263-
}
264-
265259
test("log") {
266260
runQueryAndCompare("SELECT log(10, l_orderkey) from lineitem limit 1") {
267261
checkGlutenPlan[ProjectExecTransformer]

cpp/velox/operators/functions/RegistrationAllFunctions.cc

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,6 @@ void registerFunctionOverwrite() {
8080
// Register math functions that are present in the prestosql implementation
8181
// but not yet in the sparksql registry. These are semantically identical
8282
// to Spark's behavior for the same names.
83-
velox::registerFunction<velox::functions::LnFunction, double, double>({"ln"});
8483
velox::registerFunction<velox::functions::RadiansFunction, double, double>({"radians"});
8584
velox::registerFunction<velox::functions::SinFunction, double, double>({"sin"});
8685
velox::registerFunction<velox::functions::TanFunction, double, double>({"tan"});

0 commit comments

Comments
 (0)