Skip to content

[VL] Enable cast decimal as string tests #12160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rui-mo wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[VL] Enable cast decimal as string tests #12160

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ep/build-velox/src/get-velox.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ RUN_SETUP_SCRIPT=ON
ENABLE_ENHANCED_FEATURES=OFF

# Developer use only for testing Velox PR.
UPSTREAM_VELOX_PR_ID=""
UPSTREAM_VELOX_PR_ID="17647"

OS=`uname -s`

Expand Down
3 changes: 0 additions & 3 deletions gluten-ut/spark34/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,6 @@ class VeloxTestSettings extends BackendTestSettings {
.exclude("cast string to timestamp")
.exclude("cast from timestamp II")
.exclude("SPARK-36286: invalid string cast to timestamp")
.exclude("SPARK-39749: cast Decimal to string")
// See https://github.com/facebookincubator/velox/issues/17593.
.exclude("Fast fail for cast string type to decimal type")
enableSuite[GlutenTryCastSuite]
Expand All @@ -117,8 +116,6 @@ class VeloxTestSettings extends BackendTestSettings {
.exclude("data type casting")
// Revised by setting timezone through config and commented unsupported cases.
.exclude("cast string to timestamp")
// TODO: fix after https://github.com/facebookincubator/velox/pull/14910
.exclude("SPARK-39749: cast Decimal to string")
// See https://github.com/facebookincubator/velox/issues/17593.
.exclude("Fast fail for cast string type to decimal type in ansi mode")
enableSuite[GlutenCollectionExpressionsSuite]
Expand Down
3 changes: 0 additions & 3 deletions gluten-ut/spark35/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,6 @@ class VeloxTestSettings extends BackendTestSettings {
.exclude("cast string to timestamp")
.exclude("cast from timestamp II")
.exclude("SPARK-36286: invalid string cast to timestamp")
.exclude("SPARK-39749: cast Decimal to string")
// See https://github.com/facebookincubator/velox/issues/17593.
.exclude("Fast fail for cast string type to decimal type")
enableSuite[GlutenTryCastSuite]
Expand All @@ -117,8 +116,6 @@ class VeloxTestSettings extends BackendTestSettings {
.exclude("data type casting")
// Revised by setting timezone through config and commented unsupported cases.
.exclude("cast string to timestamp")
// TODO: fix after https://github.com/facebookincubator/velox/pull/14910
.exclude("SPARK-39749: cast Decimal to string")
// See https://github.com/facebookincubator/velox/issues/17593.
.exclude("Fast fail for cast string type to decimal type in ansi mode")
enableSuite[GlutenCollectionExpressionsSuite]
Expand Down
3 changes: 0 additions & 3 deletions gluten-ut/spark40/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,6 @@ class VeloxTestSettings extends BackendTestSettings {
.exclude("cast string to timestamp")
.exclude("cast from timestamp II")
.exclude("SPARK-36286: invalid string cast to timestamp")
.exclude("SPARK-39749: cast Decimal to string")
// See https://github.com/facebookincubator/velox/issues/17593.
.exclude("Fast fail for cast string type to decimal type")
enableSuite[GlutenTryCastSuite]
Expand All @@ -132,8 +131,6 @@ class VeloxTestSettings extends BackendTestSettings {
.exclude("data type casting")
// Revised by setting timezone through config and commented unsupported cases.
.exclude("cast string to timestamp")
// TODO: fix after https://github.com/facebookincubator/velox/pull/14910
.exclude("SPARK-39749: cast Decimal to string")
// See https://github.com/facebookincubator/velox/issues/17593.
.exclude("Fast fail for cast string type to decimal type in ansi mode")
enableSuite[GlutenCollectionExpressionsSuite]
Expand Down
3 changes: 0 additions & 3 deletions gluten-ut/spark41/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,6 @@ class VeloxTestSettings extends BackendTestSettings {
.exclude("cast string to timestamp")
.exclude("cast from timestamp II")
.exclude("SPARK-36286: invalid string cast to timestamp")
.exclude("SPARK-39749: cast Decimal to string")
// See https://github.com/facebookincubator/velox/issues/17593.
.exclude("Fast fail for cast string type to decimal type")
enableSuite[GlutenTryCastSuite]
Expand All @@ -137,8 +136,6 @@ class VeloxTestSettings extends BackendTestSettings {
.exclude("data type casting")
// Revised by setting timezone through config and commented unsupported cases.
.exclude("cast string to timestamp")
// TODO: fix after https://github.com/facebookincubator/velox/pull/14910
.exclude("SPARK-39749: cast Decimal to string")
// See https://github.com/facebookincubator/velox/issues/17593.
.exclude("Fast fail for cast string type to decimal type in ansi mode")
enableSuite[GlutenCollectionExpressionsSuite]
Expand Down
Loading