Skip to content

[CORE] Log error when -Xms equals -Xmx makes JVM heap shrinking ineffective #12480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xumanbu wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −0
Open

[CORE] Log error when -Xms equals -Xmx makes JVM heap shrinking ineffective #12480

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions ...re/src/main/java/org/apache/gluten/memory/memtarget/DynamicOffHeapSizingMemoryTarget.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,18 @@ public class DynamicOffHeapSizingMemoryTarget implements MemoryTarget, KnownName
ORIGINAL_MIN_HEAP_FREE_RATIO = originalMinHeapFreeRatio;
ORIGINAL_MAX_HEAP_FREE_RATIO = originalMaxHeapFreeRatio;

long maxMem = Runtime.getRuntime().maxMemory();
long initTotalMem = Runtime.getRuntime().totalMemory();
if (initTotalMem >= maxMem * 0.95) {
LOG.error(
"JVM heap appears fixed or nearly fixed (totalMemory={}, maxMemory={}). "
+ "This typically means -Xms is equal or close to -Xmx. "
+ "Explicit JVM shrinking will not be effective because the JVM "
+ "cannot return committed heap to the OS.",
initTotalMem,
maxMem);
}

if (!isJava9OrLater()) {
// For JDK 8, we cannot change MaxHeapFreeRatio programmatically at runtime.
LOG.error("Dynamic off-heap sizing is not supported before JDK 9.");
Expand Down
Loading