[VL] Fix GlutenGroupBasedUpdateTableSuite in Spark 4.x#12493
Open
zml1206 wants to merge 3 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Enables the GlutenGroupBasedUpdateTableSuite in the Velox backend Spark 4.x unit-test settings (Spark 4.0 and 4.1), while excluding a known failing test that differs in expected exception type between Velox and Spark.
Changes:
- Enable
GlutenGroupBasedUpdateTableSuitein Spark 4.0 Velox test settings, excluding"update with NOT NULL checks". - Enable
GlutenGroupBasedUpdateTableSuitein Spark 4.1 Velox test settings, excluding"update with NOT NULL checks"for the same exception-mismatch reason.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| gluten-ut/spark40/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala | Enables GlutenGroupBasedUpdateTableSuite for Spark 4.0 Velox UTs and excludes the NOT NULL check case that fails due to exception type differences. |
| gluten-ut/spark41/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala | Same as Spark 4.0: enables the suite for Spark 4.1 Velox UTs with an exclusion for the NOT NULL checks case. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
zml1206
changed the title
Comment on lines
+275
to
+277
| enableSuite[GlutenGroupBasedUpdateTableSuite] | ||
| // Velox assert_not_null throws VeloxUserError instead of SparkRuntimeException | ||
| .exclude("update with NOT NULL checks") |
Comment on lines
+265
to
+267
| enableSuite[GlutenGroupBasedUpdateTableSuite] | ||
| // Velox assert_not_null throws VeloxUserError instead of SparkRuntimeException | ||
| .exclude("update with NOT NULL checks") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.