[VL] Fix GlutenRemoveRedundantSortsSuite in Spark 4.x#12497
Open
zml1206 wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Spark 4.x (Spark 4.0 and 4.1) Gluten unit tests for redundant sort removal so they validate Gluten’s columnar sort operator (SortExecTransformer) and re-enables the suite in Velox backend test settings.
Changes:
- Rewrote
GlutenRemoveRedundantSortsSuite(Spark 4.0/4.1) to assert redundant-sort behavior by countingSortExecTransformernodes. - Added SparkConf override to disable forced SHJ for the suite to stabilize join-related sort expectations.
- Enabled
GlutenRemoveRedundantSortsSuitein Spark 4.0/4.1VeloxTestSettings, including all Gluten-prefixed tests.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| gluten-ut/spark41/src/test/scala/org/apache/spark/sql/execution/GlutenRemoveRedundantSortsSuite.scala | Replaces Spark SortExec-based assumptions with SortExecTransformer-based assertions for Spark 4.1. |
| gluten-ut/spark41/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala | Re-enables the redundant-sorts suite for Spark 4.1 Velox UTs and includes Gluten tests. |
| gluten-ut/spark40/src/test/scala/org/apache/spark/sql/execution/GlutenRemoveRedundantSortsSuite.scala | Same test rewrite as Spark 4.1, adapted for Spark 4.0 module. |
| gluten-ut/spark40/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala | Re-enables the redundant-sorts suite for Spark 4.0 Velox UTs and includes Gluten tests. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+718
to
+720
| enableSuite[GlutenRemoveRedundantSortsSuite] | ||
| // Rewrite as it check spark SortExec. | ||
| .includeAllGlutenTests() |
Comment on lines
+736
to
+738
| enableSuite[GlutenRemoveRedundantSortsSuite] | ||
| // Rewrite as it check spark SortExec. | ||
| .includeAllGlutenTests() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.