[VL] Fix GlutenSimpleSQLViewSuite in Spark 4.x#12502
Open
zml1206 wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Re-enables GlutenSimpleSQLViewSuite for Spark 4.0/4.1 Velox UTs by replacing a Spark 4.x view test that relies on Spark structured errors with a Gluten-prefixed variant that tolerates Velox’s different error surface.
Changes:
- Add a Gluten-specific test for
storeAnalyzedPlanForViewbehavior aroundALTER VIEW/ temporary views in Spark 4.0 and 4.1. - Re-enable
GlutenSimpleSQLViewSuitein Spark 4.0/4.1 Velox test settings while excluding the upstream Spark test case that fails due to error-format differences.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| gluten-ut/spark41/src/test/scala/org/apache/spark/sql/execution/GlutenSQLViewSuite.scala | Adds a Gluten-prefixed view test and helper for missing-file assertions under Spark 4.1. |
| gluten-ut/spark41/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala | Re-enables the suite and excludes the upstream Spark test that expects structured errors. |
| gluten-ut/spark40/src/test/scala/org/apache/spark/sql/execution/GlutenSQLViewSuite.scala | Adds the same Gluten-prefixed view test and helper under Spark 4.0. |
| gluten-ut/spark40/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala | Re-enables the suite and excludes the upstream Spark test that expects structured errors. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+26
to
+34
| private def assertMissingFileError(f: => Unit): Unit = { | ||
| val exception = intercept[SparkException](f) | ||
| val messages = Iterator | ||
| .iterate[Throwable](exception)(_.getCause) | ||
| .takeWhile(_ != null) | ||
| .flatMap(e => Option(e.getMessage)) | ||
|
|
||
| assert(messages.exists(_.contains("FILE_NOT_FOUND"))) | ||
| } |
Comment on lines
+26
to
+34
| private def assertMissingFileError(f: => Unit): Unit = { | ||
| val exception = intercept[SparkException](f) | ||
| val messages = Iterator | ||
| .iterate[Throwable](exception)(_.getCause) | ||
| .takeWhile(_ != null) | ||
| .flatMap(e => Option(e.getMessage)) | ||
|
|
||
| assert(messages.exists(_.contains("FILE_NOT_FOUND"))) | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.