Skip to content

Commit b1662fc

Browse files
committed
[#11094] fix(client-python): fix group IT config not applied in CI
Fix setUpClass to always modify gravitino.conf and restart the server when running under Gradle (START_EXTERNAL_GRAVITINO=true). Add tearDownClass to restore the config after tests.
1 parent d8d7ee9 commit b1662fc

1 file changed

Lines changed: 26 additions & 12 deletions

File tree

clients/client-python/tests/integration/test_group_management.py

Lines changed: 26 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -36,25 +36,39 @@ class TestGroupManagement(IntegrationTestEnv):
3636

3737
@classmethod
3838
def setUpClass(cls):
39-
if not (
39+
cls._get_gravitino_home()
40+
conf_path = os.path.join(cls.gravitino_home, "conf", "gravitino.conf")
41+
cls._reset_conf(
42+
{"gravitino.authorization.enable": "true"}, conf_path
43+
)
44+
cls._append_conf(
45+
{"gravitino.authorization.enable": "true"}, conf_path
46+
)
47+
if (
4048
os.environ.get("START_EXTERNAL_GRAVITINO") is not None
4149
and os.environ.get("START_EXTERNAL_GRAVITINO").lower() == "true"
4250
):
43-
cls._get_gravitino_home()
44-
conf_path = os.path.join(
45-
cls.gravitino_home, "conf", "gravitino.conf"
46-
)
47-
cls._reset_conf(
48-
{"gravitino.authorization.enable": "true"}, conf_path
49-
)
50-
cls._append_conf(
51-
{"gravitino.authorization.enable": "true"}, conf_path
52-
)
53-
super().setUpClass()
51+
cls.restart_server()
52+
else:
53+
super().setUpClass()
5454
cls._gravitino_admin_client = GravitinoAdminClient(
5555
uri="http://localhost:8090"
5656
)
5757

58+
@classmethod
59+
def tearDownClass(cls):
60+
conf_path = os.path.join(cls.gravitino_home, "conf", "gravitino.conf")
61+
cls._reset_conf(
62+
{"gravitino.authorization.enable": "false"}, conf_path
63+
)
64+
if (
65+
os.environ.get("START_EXTERNAL_GRAVITINO") is not None
66+
and os.environ.get("START_EXTERNAL_GRAVITINO").lower() == "true"
67+
):
68+
cls.restart_server()
69+
else:
70+
super().tearDownClass()
71+
5872
def setUp(self):
5973
self._gravitino_admin_client.create_metalake(
6074
self._metalake_name, comment="test group management", properties={}

0 commit comments

Comments
 (0)