Trivial refactor: extract variable to avoid invoking same method repeatedly

daniellansun · daniellansun · commit 163f737d1c90 · 2025-05-24T17:59:27.000+09:00
diff --git a/src/main/java/org/codehaus/groovy/vmplugin/v8/Selector.java b/src/main/java/org/codehaus/groovy/vmplugin/v8/Selector.java
@@ -323,10 +323,11 @@ public void chooseMeta(MetaClassImpl mci) {
 
             selectionBase = sender;
             if (sender != mci.getTheClass()) {
+                final Class<?> thisType;
                 if (GroovyCategorySupport.hasCategoryInCurrentThread()) { // slow path for category property
                     selectionBase = mci.getTheClass();
-                } else if (getThisType(sender).isInstance(receiver)) { // GROOVY-5438 for private property
-                    selectionBase = getThisType(sender);
+                } else if ((thisType = getThisType(sender)).isInstance(receiver)) { // GROOVY-5438 for private property
+                    selectionBase = thisType;
                 }
             }
             if (LOG_ENABLED) LOG.info("selectionBase set to " + selectionBase);

Original file line number	Diff line number	Diff line change
`@@ -323,10 +323,11 @@ public void chooseMeta(MetaClassImpl mci) {`
`323`	`323`
`324`	`324`	`selectionBase = sender;`
`325`	`325`	`if (sender != mci.getTheClass()) {`
	`326`	`+ final Class<?> thisType;`
`326`	`327`	`if (GroovyCategorySupport.hasCategoryInCurrentThread()) { // slow path for category property`
`327`	`328`	`selectionBase = mci.getTheClass();`
`328`		`- } else if (getThisType(sender).isInstance(receiver)) { // GROOVY-5438 for private property`
`329`		`- selectionBase = getThisType(sender);`
	`329`	`+ } else if ((thisType = getThisType(sender)).isInstance(receiver)) { // GROOVY-5438 for private property`
	`330`	`+ selectionBase = thisType;`
`330`	`331`	`}`
`331`	`332`	`}`
`332`	`333`	`if (LOG_ENABLED) LOG.info("selectionBase set to " + selectionBase);`