GROOVY-9530: load static field value under configureClassNode(...)

Author: eric-milles

src/main/java/org/apache/groovy/ast/tools/ExpressionUtils.java

@@ -278,7 +278,7 @@ public static Expression transformInlineConstants(final Expression exp, final Cl
                     if (e instanceof ConstantExpression) {
                         return e;
                     }
-                } else if (cn.isResolved()) {
+                }/* else if (cn.isResolved()) { // GROOVY-9530
                     try {
                         var field = cn.getTypeClass().getField(pe.getPropertyAsString());
                         if (field != null) {
@@ -287,7 +287,7 @@ public static Expression transformInlineConstants(final Expression exp, final Cl
                     } catch (Exception | LinkageError ignore) {
                         // leave property expression and we will report later
                     }
-                }
+                }*/
             }
         } else if (exp instanceof VariableExpression) {
             VariableExpression ve = (VariableExpression) exp;

src/main/java/org/codehaus/groovy/vmplugin/v8/Java8.java

@@ -62,6 +62,7 @@
 import java.lang.reflect.MalformedParameterizedTypeException;
 import java.lang.reflect.Member;
 import java.lang.reflect.Method;
+import java.lang.reflect.Modifier;
 import java.lang.reflect.ParameterizedType;
 import java.lang.reflect.ReflectPermission;
 import java.lang.reflect.Type;
@@ -393,7 +394,7 @@ public void configureClassNode(final CompileUnit compileUnit, final ClassNode cl
             Field[] fields = clazz.getDeclaredFields();
             for (Field f : fields) {
                 ClassNode rt = makeClassNode(compileUnit, f.getGenericType(), f.getType());
-                FieldNode fn = new FieldNode(f.getName(), f.getModifiers(), rt, classNode, null);
+                FieldNode fn = new FieldNode(f.getName(), f.getModifiers(), rt, classNode, getValue(f));
                 setAnnotationMetaData(f.getAnnotations(), fn);
                 classNode.addField(fn);
             }
@@ -440,6 +441,26 @@ public void configureClassNode(final CompileUnit compileUnit, final ClassNode cl
         }
     }
 
+    /**
+     * Returns the initial expression for given field.
+     *
+     * @return value expression or null
+     * @since 5.0.0
+     */
+    protected Expression getValue(final Field field) {
+        int modifiers = field.getModifiers();
+        // TODO: read ConstantValue from field attributes
+        if (Modifier.isFinal(modifiers) && Modifier.isStatic(modifiers)
+                && (Modifier.isPublic(modifiers) || Modifier.isProtected(modifiers))
+                && (field.getType().isPrimitive() || field.getType().equals(String.class))) {
+            try {
+                return new ConstantExpression(field.get(null), true);
+            } catch (ReflectiveOperationException | LinkageError e) {
+            }
+        }
+        return null;
+    }
+
     /**
      * Synthetic parameters such as those added for inner class constructors may
      * not be included in the parameter annotations array. This is the case when

src/test/groovy/bugs/Groovy9530.groovy

@@ -18,28 +18,29 @@
  */
 package bugs
 
-import org.junit.jupiter.api.Test
+import org.codehaus.groovy.classgen.asm.AbstractBytecodeTestCase
 
-import static groovy.test.GroovyAssert.assertScript
-
-final class Groovy9530 {
+final class Groovy9530 extends AbstractBytecodeTestCase {
 
     static class StaticClass {
         public static final int STATIC_VALUE = getStaticValue()
 
         private static int getStaticValue() {
-            return 'resource from classpath'.length()
+            getClassLoader().getResources('absent thingy').toList().size()
         }
     }
 
-    @Test
     void testConstantInlining() {
-        assertScript """import bugs.Groovy9530.StaticClass
+        def bytecode = compile '''import bugs.Groovy9530.StaticClass
             class C {
                 public static final int VALUE = StaticClass.STATIC_VALUE
             }
-
-            assert C.VALUE == 23
-        """
+        '''
+        assert bytecode.hasSequence([
+            'public final static I VALUE'
+        ])
+        assert !bytecode.hasSequence([
+            'public final static I VALUE = 0' // no initializer should exist!
+        ])
     }
 }