GROOVY-11998: Better support of intersection types (copilot review)

Author: paulk-asert

src/main/java/org/codehaus/groovy/ast/IntersectionTypeClassNode.java

@@ -48,7 +48,7 @@
  * interfaces array contains only interface components and the superclass is
  * the (at most one) class component.
  *
- * @since 5.0.0
+ * @since 6.0.0
  */
 public final class IntersectionTypeClassNode extends ClassNode {
 

src/main/java/org/codehaus/groovy/classgen/asm/sc/AbstractFunctionalInterfaceWriter.java

@@ -90,7 +90,7 @@ default void writeFunctionalInterfaceIndy(final MethodVisitor methodVisitor,
      * {@code LambdaMetafactory.altMetafactory} via {@code FLAG_MARKERS} so the
      * generated lambda implements every component interface at runtime.
      *
-     * @since 5.0.0
+     * @since 6.0.0
      */
     default void writeFunctionalInterfaceIndy(final MethodVisitor methodVisitor,
                                               final String samMethodName, final String invokedTypeDescriptor,

src/main/java/org/codehaus/groovy/runtime/IntersectionCastSupport.java

@@ -35,7 +35,7 @@
  * reference (those cases are handled at compile time via
  * {@code LambdaMetafactory.altMetafactory} markers).
  *
- * @since 5.0.0
+ * @since 6.0.0
  */
 public final class IntersectionCastSupport {
 

src/spec/doc/core-semantics.adoc

@@ -793,7 +793,7 @@ include::../test/CoercionTest.groovy[tags=intersection_as_coercion_marker,indent
 ----
 
 For closure literals and maps, `as` builds a
-{@link groovy.util.ProxyGenerator} aggregate that implements every interface
+`groovy.util.ProxyGenerator` aggregate that implements every interface
 component:
 
 [source,groovy]

src/test/groovy/groovy/transform/stc/IntersectionCastSTCTest.groovy

@@ -39,9 +39,9 @@ import org.junit.jupiter.api.Test
 /**
  * Tests for static type checking of intersection-cast targets (GROOVY-11998 PR2).
  *
- * These tests stop compilation at {@link Phases#SEMANTIC_ANALYSIS} so they
- * exercise resolution and STC without relying on bytecode generation, which
- * is delivered in subsequent phases.
+ * These tests stop compilation at {@link Phases#INSTRUCTION_SELECTION} so they
+ * exercise resolution and STC without producing class files, which keeps the
+ * tests focused on resolution/STC behavior delivered in this PR.
  */
 final class IntersectionCastSTCTest {
 

src/test/groovy/org/apache/groovy/parser/antlr4/IntersectionCastParserTest.groovy

@@ -22,7 +22,6 @@ import org.codehaus.groovy.ast.ClassNode
 import org.codehaus.groovy.ast.IntersectionTypeClassNode
 import org.codehaus.groovy.ast.ModuleNode
 import org.codehaus.groovy.ast.expr.CastExpression
-import org.codehaus.groovy.ast.expr.ClassExpression
 import org.codehaus.groovy.ast.expr.DeclarationExpression
 import org.codehaus.groovy.ast.expr.Expression
 import org.codehaus.groovy.ast.expr.BinaryExpression
@@ -36,7 +35,6 @@ import org.junit.jupiter.api.Test
 import static org.junit.jupiter.api.Assertions.assertNotNull
 import static org.junit.jupiter.api.Assertions.assertTrue
 import static org.junit.jupiter.api.Assertions.assertEquals
-import static org.junit.jupiter.api.Assertions.assertThrows
 
 /**
  * Tests for the parser-level handling of intersection types in cast expressions