Skip to content

GROOVY-11630: optimize void groovy method return in expression statement#2203

Merged
eric-milles merged 1 commit into
masterfrom
GROOVY-11360
Apr 21, 2025
Merged

GROOVY-11630: optimize void groovy method return in expression statement#2203
eric-milles merged 1 commit into
masterfrom
GROOVY-11360

Conversation

@eric-milles
Copy link
Copy Markdown
Member

consolidate metadata keys to shared value

@paulk-asert
Copy link
Copy Markdown
Contributor

LGTM;

@eric-milles eric-milles merged commit 4669b32 into master Apr 21, 2025
41 checks passed
@eric-milles eric-milles deleted the GROOVY-11360 branch April 21, 2025 21:55
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 68.9506%. Comparing base (840e57a) to head (31eb3d9).
⚠️ Report is 790 commits behind head on master.

Files with missing lines Patch % Lines
...codehaus/groovy/classgen/asm/InvocationWriter.java 0.0000% 0 Missing and 1 partial ⚠️
...groovy/classgen/asm/sc/StaticInvocationWriter.java 66.6667% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##               master      #2203        +/-   ##
==================================================
+ Coverage     68.9489%   68.9506%   +0.0018%     
- Complexity      29562      29564         +2     
==================================================
  Files            1423       1423                
  Lines          113909     113909                
  Branches        19754      19754                
==================================================
+ Hits            78539      78541         +2     
+ Misses          28773      28770         -3     
- Partials         6597       6598         +1     
Files with missing lines Coverage Δ
...rg/codehaus/groovy/classgen/AsmClassGenerator.java 85.1608% <ø> (ø)
...us/groovy/classgen/asm/BinaryExpressionHelper.java 89.1589% <100.0000%> (ø)
...ssgen/asm/BinaryExpressionMultiTypeDispatcher.java 88.8325% <100.0000%> (ø)
.../codehaus/groovy/classgen/asm/StatementWriter.java 96.9613% <100.0000%> (-0.0167%) ⬇️
...taticTypesBinaryExpressionMultiTypeDispatcher.java 78.9809% <100.0000%> (ø)
...codehaus/groovy/classgen/asm/InvocationWriter.java 86.5702% <0.0000%> (ø)
...groovy/classgen/asm/sc/StaticInvocationWriter.java 74.8731% <66.6667%> (-0.1269%) ⬇️

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants