Skip to content

GROOVY-11650: Create drain extension method for Queues#2212

Merged
paulk-asert merged 1 commit into
apache:masterfrom
paulk-asert:groovy11650
May 6, 2025
Merged

GROOVY-11650: Create drain extension method for Queues#2212
paulk-asert merged 1 commit into
apache:masterfrom
paulk-asert:groovy11650

Conversation

@paulk-asert
Copy link
Copy Markdown
Contributor

No description provided.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.9613%. Comparing base (71ca3e0) to head (54441cd).
⚠️ Report is 425 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##               master      #2212        +/-   ##
==================================================
+ Coverage     68.9576%   68.9613%   +0.0037%     
- Complexity      29591      29598         +7     
==================================================
  Files            1423       1423                
  Lines          114102     114106         +4     
  Branches        19793      19794         +1     
==================================================
+ Hits            78682      78689         +7     
  Misses          28800      28800                
+ Partials         6620       6617         -3     
Files with missing lines Coverage Δ
.../codehaus/groovy/runtime/DefaultGroovyMethods.java 74.3971% <100.0000%> (+0.0305%) ⬆️

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@daniellansun
Copy link
Copy Markdown
Contributor

+1

@daniellansun daniellansun requested a review from Copilot May 5, 2025 07:39
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new extension method, drain, to the DefaultGroovyMethods class to drain queues into a list.

  • Introduces a drain method that repeatedly polls a Queue until it is empty.
  • Updates the file DefaultGroovyMethods.java with the new drain functionality.

@paulk-asert paulk-asert merged commit c3c909c into apache:master May 6, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants