Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -1951,7 +1951,14 @@ static GenericsType getCombinedGenericsType(final GenericsType gt1, final Generi
// GROOVY-11028, et al.: empty list / map for gt1 or gt2?
if (gt2.isPlaceholder() && gt2.getName().startsWith("#")) return gt1;
if (gt1.isPlaceholder() && gt1.getName().startsWith("#")) return gt2;
// GROOVY-10315, GROOVY-10317, GROOVY-10339, ...
// GROOVY-10315, GROOVY-10317, GROOVY-10339, GROOVY-11616
if (!gt1.isPlaceholder() && !gt1.isWildcard()
&& !gt2.isPlaceholder() && !gt2.isWildcard()) {
ClassNode lub = lowestUpperBound(gt1.getType(), gt2.getType());
if (!(lub instanceof WideningCategories.LowestUpperBoundClassNode)) {
return new GenericsType(lub);
}
}
ClassNode cn1 = GenericsUtils.makeClassSafe0(CLASS_Type, gt1);
ClassNode cn2 = GenericsUtils.makeClassSafe0(CLASS_Type, gt2);
ClassNode lub = lowestUpperBound(cn1, cn2);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5620,7 +5620,7 @@ private Map<GenericsTypeName, GenericsType> extractGenericsConnectionsFromArgume
}

connections.forEach((gtn, gt) -> resolvedPlaceholders.merge(gtn, gt, (gt1, gt2) -> {
// GROOVY-10339: incorporate another witness
// GROOVY-10339, GROOVY-11616: incorporate another type witness
return getCombinedGenericsType(gt1, gt2);
}));
}
Expand Down
13 changes: 13 additions & 0 deletions src/test/groovy/groovy/transform/stc/GenericsSTCTest.groovy
Original file line number Diff line number Diff line change
Expand Up @@ -250,6 +250,19 @@ class GenericsSTCTest extends StaticTypeCheckingTestCase {
def list = Arrays.asList()
assert list.size() == 0
'''

// GROOVY-11616:
assertScript '''
class A {}
class B extends A {}
class C extends B {}
@ASTTest(phase=INSTRUCTION_SELECTION, value={
def type = node.getNodeMetaData(INFERRED_TYPE)
assert type.toString(false) == 'java.util.List<A>'
})
def list = Arrays.asList(new A(), new B(), new C())
assert list.size() == 3
'''
}

// GROOVY-10062
Expand Down