Skip to content

GROOVY-11663: STC: error for class or trait property expression#2221

Merged
eric-milles merged 3 commits into
masterfrom
GROOVY-11663
May 15, 2025
Merged

GROOVY-11663: STC: error for class or trait property expression#2221
eric-milles merged 3 commits into
masterfrom
GROOVY-11663

Conversation

@eric-milles
Copy link
Copy Markdown
Member

property and attribute have very similar checking and reporting

@eric-milles eric-milles requested a review from paulk-asert May 13, 2025 17:52
@apache apache deleted a comment from codecov-commenter May 14, 2025
@apache apache deleted a comment from codecov-commenter May 14, 2025
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 14, 2025

Codecov Report

Attention: Patch coverage is 89.47368% with 6 lines in your changes missing coverage. Please review.

Project coverage is 69.1607%. Comparing base (d51a0b6) to head (bb5b1f1).
Report is 102 commits behind head on master.

Files with missing lines Patch % Lines
...va/org/codehaus/groovy/control/StaticVerifier.java 82.3529% 1 Missing and 2 partials ⚠️
...oovy/transform/stc/TraitTypeCheckingExtension.java 85.0000% 0 Missing and 3 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##               master      #2221        +/-   ##
==================================================
+ Coverage     68.9964%   69.1607%   +0.1642%     
- Complexity      29668      30552       +884     
==================================================
  Files            1423       1423                
  Lines          114332     116867      +2535     
  Branches        19835      20297       +462     
==================================================
+ Hits            78885      80826      +1941     
- Misses          28816      29342       +526     
- Partials         6631       6699        +68     
Files with missing lines Coverage Δ
...roovy/transform/stc/StaticTypeCheckingVisitor.java 87.5493% <100.0000%> (+0.0493%) ⬆️
...va/org/codehaus/groovy/control/StaticVerifier.java 94.0000% <82.3529%> (+0.1225%) ⬆️
...oovy/transform/stc/TraitTypeCheckingExtension.java 84.6154% <85.0000%> (+0.2404%) ⬆️

... and 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@eric-milles eric-milles merged commit 5eeb6b1 into master May 15, 2025
41 checks passed
@eric-milles eric-milles deleted the GROOVY-11663 branch May 15, 2025 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants