Skip to content

GROOVY-11658: groovyc: log the command-line arguments at verbose level #2222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eric-milles merged 1 commit into from
May 14, 2025
Merged

GROOVY-11658: groovyc: log the command-line arguments at verbose level #2222

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions subprojects/groovy-ant/src/main/java/org/codehaus/groovy/ant/Groovyc.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@
import java.io.FileWriter;
import java.io.IOException;
import java.io.PrintWriter;
import java.io.Writer;
import java.net.URI;
import java.net.URISyntaxException;
import java.nio.charset.Charset;
Expand Down Expand Up @@ -1255,7 +1254,7 @@ private PrintWriter printWriter(File tempFile) throws IOException {

private String[] makeCommandLine(List<String> commandLineList) {
String[] commandLine = commandLineList.toArray(String[]::new);
log.info("Compilation arguments:\n" + String.join("\n", commandLine));
log.verbose("Compilation arguments:\n" + String.join("\n", commandLine)); // GROOVY-11658
return commandLine;
}

Expand Down Expand Up @@ -1313,20 +1312,17 @@ private void runCompiler(String[] commandLine) {
// unwrap to the real exception
t = e.getCause();
}
Writer writer = new StringBuilderWriter();
var writer = new StringBuilderWriter();
new ErrorReporter(t, false).write(new PrintWriter(writer));
String message = writer.toString();
log.error(writer.toString());

taskSuccess = false;
if (errorProperty != null) {
getProject().setNewProperty(errorProperty, "true");
}

if (failOnError) {
log.error(message);
throw new BuildException("Compilation Failed", t, getLocation());
} else {
log.error(message);
}
}
}
Expand Down Expand Up @@ -1409,7 +1405,7 @@ protected GroovyClassLoader buildClassLoaderFor() {

ClassLoader loader = getClass().getClassLoader();
if (loader instanceof AntClassLoader) {
AntClassLoader antLoader = (AntClassLoader) loader;
@SuppressWarnings("resource") AntClassLoader antLoader = (AntClassLoader) loader;
String[] pathElm = antLoader.getClasspath().split(File.pathSeparator, -1);
List<String> classpath = configuration.getClasspath();
/*
Expand Down