Skip to content

GROOVY-11627: SC: disable mixed public and private overloads checking#2223

Merged
eric-milles merged 1 commit into
masterfrom
GROOVY-11627
May 16, 2025
Merged

GROOVY-11627: SC: disable mixed public and private overloads checking#2223
eric-milles merged 1 commit into
masterfrom
GROOVY-11627

Conversation

@eric-milles
Copy link
Copy Markdown
Member

I kept tests for the error and changed the trait test to work. It looked like the better example of a supported scenario.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 14, 2025

Codecov Report

❌ Patch coverage is 85.71429% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 69.0093%. Comparing base (b70de71) to head (85a4689).
⚠️ Report is 746 commits behind head on master.

Files with missing lines Patch % Lines
src/main/java/groovy/lang/MetaClassImpl.java 84.2105% 0 Missing and 3 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##               master      #2223        +/-   ##
==================================================
+ Coverage     69.0020%   69.0093%   +0.0073%     
- Complexity      29668      29670         +2     
==================================================
  Files            1423       1423                
  Lines          114317     114315         -2     
  Branches        19830      19830                
==================================================
+ Hits            78881      78888         +7     
+ Misses          28803      28798         -5     
+ Partials         6633       6629         -4     
Files with missing lines Coverage Δ
...ehaus/groovy/classgen/ClassCompletionVerifier.java 84.1418% <100.0000%> (+0.0296%) ⬆️
src/main/java/groovy/lang/MetaClassImpl.java 78.2633% <84.2105%> (+0.0192%) ⬆️

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@eric-milles eric-milles merged commit 9299d69 into master May 16, 2025
41 checks passed
@eric-milles eric-milles deleted the GROOVY-11627 branch May 16, 2025 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants