Skip to content

GROOVY-11667: GPathResult: overload getAttribute and setAttribute#2226

Merged
eric-milles merged 1 commit into
masterfrom
GROOVY-11667
May 17, 2025
Merged

GROOVY-11667: GPathResult: overload getAttribute and setAttribute#2226
eric-milles merged 1 commit into
masterfrom
GROOVY-11667

Conversation

@eric-milles
Copy link
Copy Markdown
Member

inner class dispatch is slightly different to support outer class member access

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 16, 2025

Codecov Report

❌ Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 69.0250%. Comparing base (9299d69) to head (ce20f1b).
⚠️ Report is 733 commits behind head on master.

Files with missing lines Patch % Lines
...in/java/groovy/xml/slurpersupport/GPathResult.java 50.0000% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##               master      #2226        +/-   ##
==================================================
+ Coverage     69.0228%   69.0250%   +0.0023%     
- Complexity      29685      29686         +1     
==================================================
  Files            1423       1423                
  Lines          114342     114344         +2     
  Branches        19842      19842                
==================================================
+ Hits            78922      78926         +4     
+ Misses          28786      28785         -1     
+ Partials         6634       6633         -1     
Files with missing lines Coverage Δ
...in/java/groovy/xml/slurpersupport/GPathResult.java 82.2335% <50.0000%> (-0.8434%) ⬇️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@eric-milles eric-milles changed the title GROOVY-11667: GPathResult: overload getAttribute / setAttribute GROOVY-11667: GPathResult: overload getAttribute and setAttribute May 17, 2025
@eric-milles eric-milles merged commit 7db7f05 into master May 17, 2025
41 checks passed
@eric-milles eric-milles deleted the GROOVY-11667 branch May 17, 2025 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants