Skip to content

misc(groovy-console): fix spelling#2236

Closed
jbampton wants to merge 1 commit into
apache:masterfrom
jbampton:fix-spelling
Closed

misc(groovy-console): fix spelling#2236
jbampton wants to merge 1 commit into
apache:masterfrom
jbampton:fix-spelling

Conversation

@jbampton
Copy link
Copy Markdown
Member

No description provided.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 26, 2025

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 69.0378%. Comparing base (325aff6) to head (0073c49).
Report is 68 commits behind head on master.

Files with missing lines Patch % Lines
...onsole/ui/text/StructuredSyntaxDocumentFilter.java 0.0000% 5 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##               master      #2236   +/-   ##
=============================================
  Coverage     69.0378%   69.0378%           
+ Complexity      29706      29705    -1     
=============================================
  Files            1423       1423           
  Lines          114420     114420           
  Branches        19855      19855           
=============================================
  Hits            78993      78993           
  Misses          28788      28788           
  Partials         6639       6639           
Files with missing lines Coverage Δ
...onsole/ui/text/StructuredSyntaxDocumentFilter.java 0.5714% <0.0000%> (ø)

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@paulk-asert
Copy link
Copy Markdown
Contributor

Nice catch. To avoid breaking existing code, we'd keep the old accessor method and mark it as deprecated. Did you want to adjust your PR, or are you happy for us to tweak it after merging?

@jbampton
Copy link
Copy Markdown
Member Author

Thanks @paulk-asert I am happy for a merge now.

Perhaps you can tweak it after then I can see the format going forwards

@paulk-asert
Copy link
Copy Markdown
Contributor

Merged, thanks!

@jbampton jbampton deleted the fix-spelling branch May 26, 2025 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants