misc(groovy-console): fix spelling#2236
Closed
jbampton wants to merge 1 commit into
Closed
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2236 +/- ##
=============================================
Coverage 69.0378% 69.0378%
+ Complexity 29706 29705 -1
=============================================
Files 1423 1423
Lines 114420 114420
Branches 19855 19855
=============================================
Hits 78993 78993
Misses 28788 28788
Partials 6639 6639
🚀 New features to boost your workflow:
|
Contributor
|
Nice catch. To avoid breaking existing code, we'd keep the old accessor method and mark it as deprecated. Did you want to adjust your PR, or are you happy for us to tweak it after merging? |
Member
Author
|
Thanks @paulk-asert I am happy for a merge now. Perhaps you can tweak it after then I can see the format going forwards |
Contributor
|
Merged, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.