Skip to content

GROOVY-9526, GROOVY-11719: pop field state on exception#2272

Merged
eric-milles merged 1 commit into
masterfrom
GROOVY-11719
Jul 25, 2025
Merged

GROOVY-9526, GROOVY-11719: pop field state on exception#2272
eric-milles merged 1 commit into
masterfrom
GROOVY-11719

Conversation

@eric-milles
Copy link
Copy Markdown
Member

@eric-milles eric-milles commented Jul 22, 2025

As described on the mailing list, ResolveVisitor#genericParameterNames can get stuck with Collections.EMPTY_MAP value if field or property visitation throws exception.

See also #2271

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jul 22, 2025

Codecov Report

❌ Patch coverage is 93.54839% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 68.0192%. Comparing base (f104983) to head (f54031d).
⚠️ Report is 83 commits behind head on master.

Files with missing lines Patch % Lines
...va/org/codehaus/groovy/control/ResolveVisitor.java 93.5484% 1 Missing and 5 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##               master      #2272        +/-   ##
==================================================
+ Coverage     68.0122%   68.0192%   +0.0070%     
  Complexity      29200      29200                
==================================================
  Files            1377       1377                
  Lines          114259     114256         -3     
  Branches        19839      19839                
==================================================
+ Hits            77710      77716         +6     
+ Misses          30211      30206         -5     
+ Partials         6338       6334         -4     
Files with missing lines Coverage Δ
...va/org/codehaus/groovy/control/ResolveVisitor.java 90.1266% <93.5484%> (-0.0373%) ⬇️

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@eric-milles eric-milles merged commit 2fa3794 into master Jul 25, 2025
41 checks passed
@eric-milles eric-milles deleted the GROOVY-11719 branch July 25, 2025 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants