GROOVY-9526, GROOVY-11719: pop field state on exception#2272
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2272 +/- ##
==================================================
+ Coverage 68.0122% 68.0192% +0.0070%
Complexity 29200 29200
==================================================
Files 1377 1377
Lines 114259 114256 -3
Branches 19839 19839
==================================================
+ Hits 77710 77716 +6
+ Misses 30211 30206 -5
+ Partials 6338 6334 -4
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As described on the mailing list,
ResolveVisitor#genericParameterNamescan get stuck withCollections.EMPTY_MAPvalue if field or property visitation throws exception.See also #2271