GROOVY-11995 groovyc ant task could support passing through system properties or jvmargs#2516
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2516 +/- ##
==================================================
+ Coverage 67.3329% 67.7906% +0.4576%
+ Complexity 32276 32256 -20
==================================================
Files 1490 1489 -1
Lines 125080 123886 -1194
Branches 22525 22243 -282
==================================================
- Hits 84220 83983 -237
+ Misses 33535 32626 -909
+ Partials 7325 7277 -48
🚀 New features to boost your workflow:
|
✅ All tests passed ✅🏷️ Commit: 7c174dd Learn more about TestLens at testlens.app. |
There was a problem hiding this comment.
Pull request overview
Adds support for passing JVM arguments and system properties through the groovyc Ant task when running in fork="true" mode, aligning the task more closely with Ant’s <java> task capabilities.
Changes:
- Add nested
<jvmarg>,<sysproperty>, and<syspropertyset>support for forked groovyc invocations. - Add
inheritAllto optionally pass all parent Ant project properties as-Dsystem properties to the forked compiler JVM. - Add tests and documentation covering the new forked JVM argument/property wiring and precedence rules.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| subprojects/groovy-ant/src/main/java/org/codehaus/groovy/ant/Groovyc.java | Implements forked JVM arg / sysproperty propagation and inheritAll behavior in the forked command line builder. |
| subprojects/groovy-ant/src/test/groovy/org/codehaus/groovy/ant/GroovycTest.java | Adds tests verifying JVM args, sysproperties, syspropertysets, and precedence when building the forked command line. |
| subprojects/groovy-ant/src/spec/doc/groovyc-ant-task.adoc | Documents new inheritAll attribute and the new nested elements for forked compiler configuration. |
…roperties or jvmargs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This currently combines a modified GROOVY-11994 which I was using for testing. I'll split out before merging.