GROOVY-12002: add MarkdownSlurper support to groovysh#2520
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2520 +/- ##
==================================================
+ Coverage 67.8394% 68.0867% +0.2474%
- Complexity 32547 32628 +81
==================================================
Files 1497 1497
Lines 124870 124876 +6
Branches 22478 22480 +2
==================================================
+ Hits 84711 85024 +313
+ Misses 32798 32386 -412
- Partials 7361 7466 +105
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Adds Markdown support to groovysh’s /slurp command (GROOVY-12002), leveraging the optional groovy-markdown module when present, and documents/highlights the new capability.
Changes:
- Extend
/slurpformat detection and slurper registry to support Markdown (.md/.markdown) viagroovy.markdown.MarkdownSlurper. - Add a system test covering Markdown slurping behavior (with
groovyMarkdownadded as a test dependency). - Update groovysh reference docs and add a Markdown syntax highlighter definition (
nanorc).
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| subprojects/groovy-groovysh/src/main/groovy/org/apache/groovy/groovysh/jline/GroovyCommands.groovy | Registers MARKDOWN slurper and detects .md/.markdown extensions for /slurp. |
| subprojects/groovy-groovysh/src/test/groovy/org/apache/groovy/groovysh/commands/SlurpTest.groovy | Adds test asserting Markdown slurping yields iterable structured elements. |
| subprojects/groovy-groovysh/src/spec/doc/groovysh.adoc | Documents Markdown as a supported /slurp format and describes returned type/triggering extensions. |
| subprojects/groovy-groovysh/src/main/resources/nanorc/markdown.nanorc | Adds Markdown syntax highlighting rules for the JLine highlighter. |
| subprojects/groovy-groovysh/build.gradle | Adds projects.groovyMarkdown as a test dependency for Markdown /slurp coverage. |
🚨 TestLens detected 97 failed tests 🚨Here is what you can do:
Test Summary
🏷️ Commit: 86aed1d Test Failures (first 5 of 97)BugsStaticCompileTest > testServletError() (:test in Build and test / lts (17, macos-latest))GenericsSTCTest > testAssertJ() (:test in Build and test / lts (17, macos-latest))GenericsSTCTest > testGenericsAtMethodLevelWithGenericsInTypeOfGenericType() (:test in Build and test / lts (17, macos-latest))GenericsSTCTest > testMockito() (:test in Build and test / lts (17, macos-latest))GenericsSTCTest > testReturnTypeInferenceWithMethodGenerics18() (:test in Build and test / lts (17, macos-latest))Muted TestsSelect tests to mute in this pull request:
Reuse successful test results:
Click the checkbox to trigger a rerun:
Learn more about TestLens at testlens.app. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.