reject ?> and -- in markup builder pi and comment output#2625
Closed
netliomax25-code wants to merge 1 commit into
Closed
reject ?> and -- in markup builder pi and comment output#2625netliomax25-code wants to merge 1 commit into
netliomax25-code wants to merge 1 commit into
Conversation
Contributor
|
Merged as part of #2626. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
<?...?>body, so a value holding?>closes the PI early and injects sibling markup. This closure backs both StreamingMarkupBuilder and StreamingDOMBuilder.<!-- ... -->through yieldUnescaped, so text holding--closes the comment early the same way.Entity escaping is not legal inside a processing instruction or comment, so the terminating sequence is rejected (
?>for the PI data,--for the comment text) rather than escaped. The builders already escape element text and attribute values, these two bodies were the gap. Regression test added for both, plus a check that ordinary PI/comment content still round-trips.