Skip to content

Commit ded1f68

Browse files
David BatemanDavid Bateman
authored andcommitted
Don't catch all exceptions in exchangeCode function
1 parent 2951f00 commit ded1f68

3 files changed

Lines changed: 1 addition & 2 deletions

File tree

extensions/guacamole-auth-sso/modules/guacamole-auth-sso-openid/src/main/java/org/apache/guacamole/auth/openid/token/TokenValidationService.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -211,7 +211,7 @@ private String exchangeCode(String code, String verifier) throws GuacamoleExcept
211211
return (String) json.get("id_token");
212212

213213
}
214-
catch (Exception e) {
214+
catch (IOException e) {
215215
logger.error("Rejected invalid OpenID code exchange: {}", e.getMessage(), e);
216216
}
217217
return null;

extensions/guacamole-auth-sso/modules/guacamole-auth-sso-openid/src/main/java/org/apache/guacamole/auth/openid/util/JsonUrlReader.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@
3131
import org.slf4j.Logger;
3232
import org.slf4j.LoggerFactory;
3333

34-
3534
/*
3635
* Utility class to open a http connection to a URL, send a body
3736
* and receive a response in the form of a parsed JSON

0 commit comments

Comments
 (0)