HDFS-17905. Clean up pendingDNMessages on block removal#8415
Merged
ZanderXu merged 1 commit intoapache:trunkfrom Apr 21, 2026
Merged
HDFS-17905. Clean up pendingDNMessages on block removal#8415ZanderXu merged 1 commit intoapache:trunkfrom
ZanderXu merged 1 commit intoapache:trunkfrom
Conversation
ZanderXu
approved these changes
Apr 13, 2026
Contributor
ZanderXu
left a comment
ZanderXu
left a comment
There was a problem hiding this comment.
Nice catch. LGTM + 1.
Please take a look at Jenkins
Contributor
|
Merged. Thanks @kokonguyen191 for your contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Since DNs do not report deleted blocks to NNs, in standby and observer namenodes, if not removed,
pendingDNMessageswill never drain messages from blocks that have already been deleted, leading to a leak.The solution is to clean up the messages when the block is removed in
BlockManager#removeBlock().How was this patch tested?
UT