Skip to content

Commit d962246

Browse files
elijahbenizzyskrawcz
authored andcommitted
Update graph_functions.py
Describes what to do in `graph_functions.py`
1 parent d90212f commit d962246

1 file changed

Lines changed: 10 additions & 0 deletions

File tree

hamilton/execution/graph_functions.py

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -205,6 +205,15 @@ def dfs_traverse(
205205
result = None
206206
success = True
207207
pre_node_execute_errored = False
208+
# TODO -- take everything from HERE to THERE
209+
# Put it in a function
210+
# That function should take an adapter as well as a node + other params (run_id, kwargs, etc...)
211+
# And output result
212+
# Then call the lifecycle method you created called do_remote_execute using the recipe below (call_lifecycle_method)
213+
# And delegate to that
214+
# only under if adapter.does_method("do_remote_execute")
215+
# Otherwise just call the function we just defined
216+
##### HERE ######
208217
try:
209218
if adapter.does_hook("pre_node_execute", is_async=False):
210219
try:
@@ -254,6 +263,7 @@ def dfs_traverse(
254263
message = create_error_message(kwargs, node_, "[post-node-execute]")
255264
logger.exception(message)
256265
raise
266+
##### THERE #####
257267

258268
computed[node_.name] = result
259269
# > pruning the graph

0 commit comments

Comments
 (0)