Enable multiple pipe_input targets#1656
Draft
Probablism wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1177
This enables multiple-target
pipe_inputbehavior and restores the corresponding targeting API and tests.Changes
pipe_input(..., on_input=[...])to target more than one function parameter.step(...).on_input(...)for per-step input targeting.pipe_inputdocstring and restore the matching unit/resource tests.How I tested this
UV_CACHE_DIR=/tmp/hamilton-uv-cache .uv-tools/bin/uv run pytest tests/function_modifiers/test_macros.py -q -k pipe_inputUV_CACHE_DIR=/tmp/hamilton-uv-cache .uv-tools/bin/uv run pytest tests/function_modifiers/test_macros.py -qUV_CACHE_DIR=/tmp/hamilton-uv-cache .uv-tools/bin/uv run pytest tests/function_modifiers tests/test_function_modifiers.py -qUV_CACHE_DIR=/tmp/hamilton-uv-cache .uv-tools/bin/uv run pytest tests/ --cov=hamilton --ignore tests/integrations -qUV_CACHE_DIR=/tmp/hamilton-uv-cache .uv-tools/bin/uv run ruff check hamilton/function_modifiers/macros.py tests/function_modifiers/test_macros.py tests/resources/pipe_input.pyUV_CACHE_DIR=/tmp/hamilton-uv-cache .uv-tools/bin/uv run ruff format --check hamilton/function_modifiers/macros.py tests/function_modifiers/test_macros.py tests/resources/pipe_input.pygit diff --checkNotes
This keeps the old default behavior for
on_input=Noneand the existing single-target behavior foron_input="param". I did not changepipe_outputormutate.Checklist