Skip to content

Commit 99d9281

Browse files
committed
HBASE-30238 Address bulkload replication review comments
1 parent 91c480f commit 99d9281

2 files changed

Lines changed: 4 additions & 2 deletions

File tree

hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/HFileReplicator.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,9 @@ public class HFileReplicator implements Closeable {
7979
public static final int REPLICATION_BULKLOAD_COPY_HFILES_PERTHREAD_DEFAULT = 10;
8080
/**
8181
* Bandwidth limit in MB/s for copying HFiles from source cluster during bulkload replication. 0
82-
* means no limit. Can be changed dynamically via configuration reload.
82+
* means no limit. Can be changed dynamically via configuration reload. A low limit can make the
83+
* sink-side bulkload copy exceed the replication RPC timeout, so configure the timeout
84+
* accordingly.
8385
*/
8486
public static final String REPLICATION_BULKLOAD_COPY_BANDWIDTH_MB_KEY =
8587
"hbase.replication.bulkload.copy.bandwidth.mb";

hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSink.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -472,7 +472,7 @@ private void addNewTableEntryInMap(
472472
bulkLoadHFileMap.put(tableName, newFamilyHFilePathsList);
473473
}
474474

475-
private static String buildBulkLoadKey(String replicationClusterId, BulkLoadDescriptor bld) {
475+
private String buildBulkLoadKey(String replicationClusterId, BulkLoadDescriptor bld) {
476476
return replicationClusterId + "#" + Bytes.toString(bld.getEncodedRegionName().toByteArray())
477477
+ "#" + bld.getBulkloadSeqNum();
478478
}

0 commit comments

Comments
 (0)