HBASE-30242 reimplement ratio as uncompressed / compressed

Author: Umeshkumar9414

hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerSource.java

@@ -248,8 +248,8 @@ public interface MetricsRegionServerSource extends BaseSource, JvmPauseMonitorSo
     "Bytes per second by which the size of storefiles being served grows.";
   String STOREFILE_UNCOMPRESSED_SIZE_DESC = "Total uncompressed size of storefiles being served.";
   String STOREFILE_COMPRESSION_RATIO_DESC =
-    "Compression ratio of storefiles (compressed/uncompressed). Lower values indicate better"
-      + " compression. Returns 1.0 when there is no data.";
+    "Compression ratio of storefiles (uncompressed/compressed). Higher values indicate better"
+      + " compression. Returns 0.0 when there is no data.";
   String TOTAL_REQUEST_COUNT = "totalRequestCount";
   String TOTAL_REQUEST_COUNT_DESC =
     "Total number of requests this RegionServer has answered; increments the count once for "

hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerWrapper.java

@@ -122,8 +122,8 @@ public interface MetricsRegionServerWrapper {
   long getStoreFileUncompressedSize();
 
   /**
-   * Get the compression ratio of store files on this region server. This is the ratio of compressed
-   * on-disk size to uncompressed data size. Returns 1.0 when there is no data.
+   * Get the compression ratio of store files on this region server. This is the ratio of
+   * uncompressed data size to compressed on-disk size. Returns 0.0 when there is no data.
    */
   double getStoreFileCompressionRatio();
 

hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerWrapperImpl.java

@@ -542,9 +542,9 @@ public long getStoreFileUncompressedSize() {
   public double getStoreFileCompressionRatio() {
     long uncompressed = aggregate.storeFileUncompressedSize;
     if (uncompressed == 0) {
-      return 1.0;
+      return 0.0;
     }
-    return (double) aggregate.storeFileSize / uncompressed;
+    return (double) uncompressed / aggregate.storeFileSize;
   }
 
   @Override

hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerWrapperStub.java

@@ -94,7 +94,7 @@ public long getStoreFileUncompressedSize() {
 
   @Override
   public double getStoreFileCompressionRatio() {
-    return 0.5;
+    return 2;
   }
 
   @Override

hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMetricsRegionServer.java

@@ -91,7 +91,7 @@ public void testWrapperSource() {
     HELPER.assertGauge("memstoreOffHeapSize", 600, serverSource);
     HELPER.assertGauge("storeFileSize", 1900, serverSource);
     HELPER.assertGauge("storeFileUncompressedSize", 3800, serverSource);
-    HELPER.assertGauge("storeFileCompressionRatio", 0.5, serverSource);
+    HELPER.assertGauge("storeFileCompressionRatio", 2.0, serverSource);
     HELPER.assertGauge("storeFileSizeGrowthRate", 50.0, serverSource);
     HELPER.assertCounter("totalRequestCount", 899, serverSource);
     HELPER.assertCounter("totalRowActionRequestCount",