HIVE-27070: Multiple is NULL check together fails in CalcitePlanner#6550
Open
soumyakanti3578 wants to merge 1 commit into
Open
HIVE-27070: Multiple is NULL check together fails in CalcitePlanner#6550soumyakanti3578 wants to merge 1 commit into
soumyakanti3578 wants to merge 1 commit into
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Added a new interface
NonNullableReturnTypeUDFto identify UDFs with a non-nullable return type.When a NonNullableReturnTypeUDF is identified in
HiveFunctionHelper.getReturnType, we can create the return type with nullability set tofalse.Currently
GenericUDFOPNullandGenericUDFOPNotNullimplements the interface.Why are the changes needed?
Calcite has a Strong policy where it validates and asserts that the output of a function like
IS NULLhas a non-nullable return type. This is done in RexSimplify.validateStrongPolicyJira: HIVE-27070
Does this PR introduce any user-facing change?
No
How was this patch tested?