Commit 6542f7c
committed
HttpsSupport: Omit public suffix matcher from default hostname verifier
The use of public suffix matching as part of hostname verification is
nonstandard. I can't find anything in the TLS specifications that
prescribe or even mention this behavior, having checked:
* RFC 8446: The Transport Layer Security (TLS) Protocol Version 1.3
* RFC 9110: HTTP Semantics
* RFC 9525: Service Identity in TLS
There are of course rules for wildcard matching, but ultimately the
question of whether to trust a certificate for `*.com` is up to the CAs
in your trust store. Given the oddity of the PSL matching behavior and
the non-trivial runtime overhead of loading and querying the PSL, I
think it makes more sense for the default `HostnameVerifier` to not use
this behavior.1 parent 1f90c1a commit 6542f7c
1 file changed
Lines changed: 1 addition & 2 deletions
Lines changed: 1 addition & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
32 | 32 | | |
33 | 33 | | |
34 | 34 | | |
35 | | - | |
36 | 35 | | |
37 | 36 | | |
38 | 37 | | |
| |||
62 | 61 | | |
63 | 62 | | |
64 | 63 | | |
65 | | - | |
| 64 | + | |
66 | 65 | | |
67 | 66 | | |
68 | 67 | | |
0 commit comments