BasicCookieStore: preserve creation time on cookie replacement#806
Merged
arturobernalg merged 1 commit intoApr 3, 2026
Merged
Conversation
Required by RFC 6265 Section 5.3; affects cookie ordering (Section 5.4)
Member
|
@arturobernalg The description does not seem to match the changes. |
Member
Author
@ok2c a mix between PR's. |
ok2c
approved these changes
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change makes BasicCookieStore#addCookie preserve the original cookie creation-time when replacing an equivalent cookie, instead of resetting it on every update.
"Update the creation-time of the newly created cookie to match the creation-time of the old-cookie."
https://datatracker.ietf.org/doc/html/rfc6265#section-5.3