Added support for request body to the cache key generator#850
Open
ok2c wants to merge 1 commit into
Open
Conversation
ok2c
force-pushed
the
feature/cache-key-generator-body-support
branch
from
e6eb8a8 to
9be506c
Compare
| final Function<T, String> bodyExtractor) { | ||
| final String s = CacheSupport.requestUriRaw(host, request); | ||
| final String body = bodyExtractor != null ? bodyExtractor.apply(request) : null; | ||
| if (body != null) { |
Contributor
There was a problem hiding this comment.
Is it supposed to fail now if the body extractor succeeds?
Member
Author
There was a problem hiding this comment.
@desiderantes This is a temporary sanity check as the caching layer simply does not work correctly with entity enclosing requests. This is something I presume you are going to fix in your pull request.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change-set extends the cache key generator with support for requests with an enclosed content body such as QUERY.
@desiderantes Please review and let me know if this approach works for you.
@arturobernalg Please double-check.