code cleanup in async request executors; fixed interface downcast ot its implementation

Author: ok2c

httpcore5-h2/src/main/java/org/apache/hc/core5/http2/impl/nio/bootstrap/H2MultiplexingRequester.java

@@ -266,11 +266,14 @@ public void failed(final Exception cause) {
                         };
                         final int max = maxCommandsPerConnection;
                         if (max > 0) {
-                            final int current = ioSession.getPendingCommandCount();
-                            if (current >= 0 && current >= max) {
-                                exchangeHandler.failed(new RejectedExecutionException(
-                                        "Maximum number of pending commands per connection reached (max=" + max + ")"));
-                                exchangeHandler.releaseResources();
+                            final int pending = ioSession.getPendingCommandCount();
+                            if (pending >= 0 && pending >= max) {
+                                try {
+                                    exchangeHandler.failed(new RejectedExecutionException(
+                                            "Maximum number of pending commands per connection reached (max=" + max + ")"));
+                                } finally {
+                                    exchangeHandler.releaseResources();
+                                }
                                 return;
                             }
                         }

httpcore5/src/main/java/org/apache/hc/core5/http/impl/bootstrap/HttpAsyncRequester.java

@@ -289,21 +289,6 @@ public void execute(
 
                     @Override
                     public void completed(final AsyncClientEndpoint endpoint) {
-                        final int max = maxPendingCommandsPerConnection;
-                        if (max > 0) {
-                            final IOSession ioSession = ((InternalAsyncClientEndpoint) endpoint).getIOSession();
-                            final int pending = ioSession.getPendingCommandCount();
-                            if (pending >= 0 && pending >= max) {
-                                try {
-                                    endpoint.releaseAndReuse();
-                                    exchangeHandler.failed(new RejectedExecutionException(
-                                            "Maximum number of pending requests per connection reached (max=" + max + ")"));
-                                } finally {
-                                    exchangeHandler.releaseResources();
-                                }
-                                return;
-                            }
-                        }
                         endpoint.execute(new AsyncClientExchangeHandler() {
 
                             @Override
@@ -521,6 +506,19 @@ public void execute(
                 final HandlerFactory<AsyncPushConsumer> pushHandlerFactory,
                 final HttpContext context) {
             final IOSession ioSession = getIOSession();
+            final int max = maxPendingCommandsPerConnection;
+            if (max > 0) {
+                final int pending = ioSession.getPendingCommandCount();
+                if (pending >= 0 && pending >= max) {
+                    try {
+                        exchangeHandler.failed(new RejectedExecutionException(
+                                "Maximum number of pending commands per connection reached (max=" + max + ")"));
+                    } finally {
+                        exchangeHandler.releaseResources();
+                    }
+                    return;
+                }
+            }
             ioSession.enqueue(
                     new RequestExecutionCommand(exchangeHandler, pushHandlerFactory, context),
                     Command.Priority.NORMAL);