Skip to content

Commit e8c82bb

Browse files
committed
* modules/ssl/ssl_engine_vars.c (ssl_var_lookup_ssl_cert_remain):
Revert workaround for OpenSSL feature/ech branch, which is now updated. Also refresh the CI cache for the feature/ech OpenSSL build. Github: closes #608 git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1932103 13f79535-47bb-0310-9956-ffa450edef68
1 parent b7bd90f commit e8c82bb

2 files changed

Lines changed: 2 additions & 5 deletions

File tree

.github/workflows/linux.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -320,7 +320,7 @@ jobs:
320320
config: --enable-mods-shared=most --enable-maintainer-mode --disable-md --disable-http2 --disable-ldap --disable-crypto
321321
notest-cflags: -Werror -O2
322322
env: |
323-
TEST_OPENSSL3=ech1
323+
TEST_OPENSSL3=ech2
324324
TEST_OPENSSL3_BRANCH=feature/ech
325325
OPENSSL_CONFIG=no-engine
326326
APR_VERSION=1.7.6

modules/ssl/ssl_engine_vars.c

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -839,10 +839,7 @@ static const char *ssl_var_lookup_ssl_cert_valid(apr_pool_t *p, ASN1_TIME *tm)
839839
* "0" if this can't be determined. */
840840
static const char *ssl_var_lookup_ssl_cert_remain(apr_pool_t *p, ASN1_TIME *tm)
841841
{
842-
/* NOTE: temporary workaround to disable this for HAVE_OPENSSL_ECH since the
843-
* feature/ech branch is missing 9fb44b527ee3717795609fb876a7a81f8898c623 */
844-
#if OPENSSL_VERSION_NUMBER >= 0x10101000L && !defined(LIBRESSL_VERSION_NUMBER) \
845-
&& !defined(HAVE_OPENSSL_ECH)
842+
#if OPENSSL_VERSION_NUMBER >= 0x10101000L && !defined(LIBRESSL_VERSION_NUMBER)
846843
int diff;
847844

848845
if (INVALID_ASN1_TIME(tm) || ASN1_TIME_diff(&diff, NULL, NULL, tm) != 1) {

0 commit comments

Comments
 (0)