fix(api): fix compilation error and address imbajin review issues

- GraphsAPI: remove duplicate private isPrefix() that shadowed the
  protected version in API base class, causing compilation failure
- GraphsAPI: fix NPE in manage() when 'update' value is null by
  guarding value.getClass() in both action and update validation
- GraphsAPI/GraphSpaceAPI: replace org.apache.commons.lang.StringUtils
  with commons-lang3 and remove org.apache.logging.log4j.util.Strings
  import (replaced with StringUtils equivalents) to fix potential
  classpath issues
- GraphManager.updateGraphNickname: restore old nickname (not null)
  on PD persistence failure to avoid a third inconsistent state
- StandardAuthManagerV2.setDefaultGraph: check existBelong() before
  createBelong() to make the operation idempotent; repeated POST calls
  for the same user/graph no longer throw HugeException
- StandardAuthManagerV2.createDefaultRole: same idempotent guard via
  existBelong() check before createBelong()
- ManagerAPI.checkDefaultRole: use @PathParam graphspace instead of
  @QueryParam to match the mounted path contract

Author: Yeaury

hugegraph-server/hugegraph-api/src/main/java/org/apache/hugegraph/api/auth/ManagerAPI.java

@@ -267,7 +267,7 @@ public String getRolesInGs(@Context GraphManager manager,
     @Path("default")
     @Consumes(APPLICATION_JSON)
     public String checkDefaultRole(@Context GraphManager manager,
-                                   @QueryParam("graphspace") String graphSpace,
+                                   @PathParam("graphspace") String graphSpace,
                                    @QueryParam("role") String role,
                                    @QueryParam("graph") String graph) {
         LOG.debug("check if current user is default role: {} {} {}",

hugegraph-server/hugegraph-api/src/main/java/org/apache/hugegraph/api/profile/GraphsAPI.java

@@ -46,7 +46,6 @@
 import org.apache.hugegraph.util.E;
 import org.apache.hugegraph.util.JsonUtil;
 import org.apache.hugegraph.util.Log;
-import org.apache.logging.log4j.util.Strings;
 import org.slf4j.Logger;
 
 import com.codahale.metrics.annotation.Timed;
@@ -213,17 +212,6 @@ public Object listProfile(@Context GraphManager manager,
         return defaultProfiles;
     }
 
-    private static boolean isPrefix(Map<String, Object> profile, String prefix) {
-        if (StringUtils.isEmpty(prefix)) {
-            return true;
-        }
-        // graph name or nickname is not empty
-        String name = profile.get("name").toString();
-        Object nicknameObj = profile.get("nickname");
-        String nickname = nicknameObj != null ? nicknameObj.toString() : "";
-        return name.startsWith(prefix) || nickname.startsWith(prefix);
-    }
-
     @GET
     @Timed
     @Path("{name}")
@@ -358,7 +346,8 @@ public Map<String, String> manage(@Context GraphManager manager,
                 value = actionMap.get(UPDATE);
                 E.checkArgument(value instanceof Map,
                                 "The '%s' must be map, but got %s",
-                                UPDATE, value.getClass());
+                                UPDATE,
+                                value == null ? "null" : value.getClass().getSimpleName());
                 @SuppressWarnings("unchecked")
                 Map<String, Object> graphMap = (Map<String, Object>) value;
                 String graphName = (String) graphMap.get("name");
@@ -367,7 +356,7 @@ public Map<String, String> manage(@Context GraphManager manager,
                                 graphName, name);
                 HugeGraph exist = graph(manager, graphSpace, name);
                 String nickname = (String) graphMap.get("nickname");
-                if (!Strings.isEmpty(nickname)) {
+                if (!StringUtils.isEmpty(nickname)) {
                     GraphManager.checkNickname(nickname);
                     E.checkArgument(!manager.isExistedGraphNickname(graphSpace, nickname) ||
                                     nickname.equals(exist.nickname()),
@@ -471,7 +460,7 @@ public Object create(@Context GraphManager manager,
         String description = (configs != null) ?
                              (String) configs.get(GRAPH_DESCRIPTION) : null;
         if (description == null) {
-            description = Strings.EMPTY;
+            description = StringUtils.EMPTY;
         }
         Object result = ImmutableMap.of("name", graph.name(),
                                         "nickname", graph.nickname(),

hugegraph-server/hugegraph-api/src/main/java/org/apache/hugegraph/api/space/GraphSpaceAPI.java

@@ -26,7 +26,7 @@
 import java.util.Set;
 
 import org.apache.commons.codec.digest.DigestUtils;
-import org.apache.commons.lang.StringUtils;
+import org.apache.commons.lang3.StringUtils;
 
 import org.apache.hugegraph.HugeException;
 import org.apache.hugegraph.api.API;
@@ -41,7 +41,6 @@
 import org.apache.hugegraph.util.E;
 import org.apache.hugegraph.util.JsonUtil;
 import org.apache.hugegraph.util.Log;
-import org.apache.logging.log4j.util.Strings;
 import org.slf4j.Logger;
 
 import com.codahale.metrics.annotation.Timed;
@@ -363,13 +362,13 @@ public Map<String, Object> manage(@Context GraphManager manager,
                 }
 
                 String nickname = (String) graphSpaceMap.get("nickname");
-                if (!Strings.isEmpty(nickname)) {
+                if (!StringUtils.isEmpty(nickname)) {
                     GraphManager.checkNickname(nickname);
                     exist.nickname(nickname);
                 }
 
                 String description = (String) graphSpaceMap.get("description");
-                if (!Strings.isEmpty(description)) {
+                if (!StringUtils.isEmpty(description)) {
                     exist.description(description);
                 }
 
@@ -410,31 +409,31 @@ public Map<String, Object> manage(@Context GraphManager manager,
                 String oltpNamespace =
                         (String) graphSpaceMap.get("oltp_namespace");
                 if (oltpNamespace != null &&
-                    !Strings.isEmpty(oltpNamespace)) {
+                    !StringUtils.isEmpty(oltpNamespace)) {
                     exist.oltpNamespace(oltpNamespace);
                 }
                 String olapNamespace =
                         (String) graphSpaceMap.get("olap_namespace");
                 if (olapNamespace != null &&
-                    !Strings.isEmpty(olapNamespace)) {
+                    !StringUtils.isEmpty(olapNamespace)) {
                     exist.olapNamespace(olapNamespace);
                 }
                 String storageNamespace =
                         (String) graphSpaceMap.get("storage_namespace");
                 if (storageNamespace != null &&
-                    !Strings.isEmpty(storageNamespace)) {
+                    !StringUtils.isEmpty(storageNamespace)) {
                     exist.storageNamespace(storageNamespace);
                 }
 
                 String operatorImagePath = (String) graphSpaceMap
                         .getOrDefault("operator_image_path", "");
-                if (!Strings.isEmpty(operatorImagePath)) {
+                if (!StringUtils.isEmpty(operatorImagePath)) {
                     exist.operatorImagePath(operatorImagePath);
                 }
 
                 String internalAlgorithmImageUrl = (String) graphSpaceMap
                         .getOrDefault("internal_algorithm_image_url", "");
-                if (!Strings.isEmpty(internalAlgorithmImageUrl)) {
+                if (!StringUtils.isEmpty(internalAlgorithmImageUrl)) {
                     exist.internalAlgorithmImageUrl(internalAlgorithmImageUrl);
                 }
 

hugegraph-server/hugegraph-api/src/main/java/org/apache/hugegraph/core/GraphManager.java

@@ -2210,6 +2210,8 @@ public void updateGraphNickname(String graphSpace, String graphName,
                                     String nickname) {
         // Always update the in-memory graph instance first
         HugeGraph g = this.graph(graphSpace, graphName);
+        // Capture the old nickname so we can restore it on failure
+        String oldNickname = g != null ? g.nickname() : null;
         if (g != null) {
             g.nickname(nickname);
         }
@@ -2226,10 +2228,10 @@ public void updateGraphNickname(String graphSpace, String graphName,
                 this.metaManager.notifyGraphUpdate(graphSpace, graphName);
             }
         } catch (Exception e) {
-            // Roll back the in-memory change so that the runtime state stays
-            // consistent with what was actually persisted.
+            // Roll back the in-memory change to the previous value so that
+            // runtime state stays consistent with what was actually persisted.
             if (g != null) {
-                g.nickname(null);
+                g.nickname(oldNickname);
             }
             throw new HugeException("Failed to persist nickname for graph " +
                                     "'%s/%s'", e, graphSpace, graphName);

hugegraph-server/hugegraph-core/src/main/java/org/apache/hugegraph/auth/StandardAuthManagerV2.java

@@ -1519,6 +1519,13 @@ public HugeGroup findGroup(String name) {
     @Override
     public void setDefaultGraph(String graphSpace, String graph, String user) {
         try {
+            String role = graph + DEFAULT_SETTER_ROLE_KEY;
+            String belongId = this.metaManager.belongId(user, role);
+            Id id = IdGenerator.of(belongId);
+            // Idempotent: if binding already exists, treat as success
+            if (this.metaManager.existBelong(graphSpace, id)) {
+                return;
+            }
             HugeBelong belong = new HugeBelong(graphSpace,
                                                IdGenerator.of(user),
                                                IdGenerator.of(graph +
@@ -1577,15 +1584,24 @@ public Id createDefaultRole(String graphSpace, String owner,
                 getGraphDefaultRole(graph, role.toString()) : role.toString();
         try {
             HugeBelong belong;
+            String link;
             if (HugeGroup.isGroup(owner)) {
                 belong = new HugeBelong(graphSpace, null,
                                         IdGenerator.of(owner),
                                         IdGenerator.of(roleName),
                                         HugeBelong.GR);
+                link = HugeBelong.GR;
             } else {
                 belong = new HugeBelong(graphSpace, IdGenerator.of(owner),
                                         null, IdGenerator.of(roleName),
                                         HugeBelong.UR);
+                link = HugeBelong.UR;
+            }
+
+            // Idempotent: if binding already exists, treat as success
+            String belongId = this.metaManager.belongId(owner, roleName, link);
+            if (this.metaManager.existBelong(graphSpace, IdGenerator.of(belongId))) {
+                return IdGenerator.of(belongId);
             }
 
             this.tryInitDefaultRole(graphSpace, roleName, graph);