chore: bump project version from 1.5.0 to 1.7.0 (#72)

* chore(server): improve log clarity and add null checks in api

* chore: bump version from 1.5.0 to 1.7.0

* chore: add todo in common pom.xml

Author: Tsukilc

hugegraph-commons/hugegraph-common/src/main/java/org/apache/hugegraph/rest/RestResult.java

@@ -37,6 +37,7 @@ public class RestResult {
 
     static {
         MAPPER.disable(SerializationFeature.WRITE_DATES_AS_TIMESTAMPS);
+        // NOTE: jackson will synchronize DateFormat
         MAPPER.setDateFormat(new SimpleDateFormat("yyyy-MM-dd HH:mm:ss.SSS"));
     }
 

hugegraph-commons/hugegraph-common/src/main/java/org/apache/hugegraph/util/JsonUtilCommon.java

@@ -40,6 +40,7 @@ public final class JsonUtilCommon {
 
     static {
         MAPPER.disable(SerializationFeature.WRITE_DATES_AS_TIMESTAMPS);
+        // NOTE: jackson will synchronize DateFormat
         MAPPER.setDateFormat(new SimpleDateFormat("yyyy-MM-dd HH:mm:ss.SSS"));
     }
 

hugegraph-commons/hugegraph-common/src/main/resources/version.properties

@@ -19,5 +19,5 @@
 Version=${revision}
 ApiVersion=0.71
 ApiCheckBeginVersion=1.0
-ApiCheckEndVersion=1.7
-VersionInBash=1.5.0
+ApiCheckEndVersion=2.0
+VersionInBash=1.7.0

hugegraph-commons/pom.xml

@@ -90,7 +90,8 @@
 
     <properties>
         <!-- Note: We need also update the version in CommonVersion.java & RpcVersion.java now -->
-        <revision>1.5.0</revision>
+        <!-- TODO: Remove the revision property below after verifying parent POM inheritance works correctly -->
+        <revision>1.7.0</revision>
         <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
         <top.level.dir>${project.basedir}/..</top.level.dir>
         <compiler.source>1.8</compiler.source>

hugegraph-server/hugegraph-api/src/main/java/org/apache/hugegraph/api/filter/AuthenticationFilter.java

@@ -330,6 +330,7 @@ private boolean matchPermission(String required) {
             if (!valid &&
                 !required.equals(HugeAuthenticator.USER_ADMIN)) {
                 LOG.info(
+                        "Permission denied for user '{}', action '{}', resource '{}'",
                         user.userId().asString(),
                         requiredPerm.action().string(),
                         requiredPerm.resourceObject());

hugegraph-server/hugegraph-api/src/main/java/org/apache/hugegraph/api/profile/GraphsAPI.java

@@ -186,6 +186,18 @@ public Object create(@Context GraphManager manager,
         HugeGraph graph;
         E.checkArgumentNotNull(gs, "Not existed graph space: '%s'", graphSpace);
 
+        // Check required parameters for creating graph
+        if (StringUtils.isEmpty(clone)) {
+            // Only check required parameters when creating new graph, not when cloning
+            E.checkArgument(configs != null, "Config parameters cannot be null");
+            String[] requiredKeys = {"backend", "serializer", "store"};
+            for (String key : requiredKeys) {
+                Object value = configs.get(key);
+                E.checkArgument(value instanceof String && !StringUtils.isEmpty((String) value),
+                                "Required parameter '%s' is missing or empty", key);
+            }
+        }
+
         // todo: auth get actual user info
         String creator = "admin";
 
@@ -198,10 +210,6 @@ public Object create(@Context GraphManager manager,
             graph = manager.createGraph(graphSpace, name, creator,
                     convConfig(configs), true);
         }
-        //if (gs.auth()) {
-        //    manager.authManager().createGraphDefaultRole(graphSpace,
-        //                                                 graph.nickname());
-        //}
         String description = (String) configs.get(GRAPH_DESCRIPTION);
         if (description == null) {
             description = Strings.EMPTY;

hugegraph-server/hugegraph-api/src/main/java/org/apache/hugegraph/api/space/GraphSpaceAPI.java

@@ -103,7 +103,7 @@ public String create(@Context GraphManager manager,
 
         jsonGraphSpace.checkCreate(false);
 
-        String creator = "test";
+        String creator = "admin";
         GraphSpace exist = manager.graphSpace(jsonGraphSpace.name);
         E.checkArgument(exist == null, "The graph space '%s' has existed",
                         jsonGraphSpace.name);
@@ -370,17 +370,17 @@ public GraphSpace toGraphSpace(String creator) {
             graphSpace.computeMemoryLimit(this.computeMemoryLimit);
             graphSpace.operatorImagePath(this.operatorImagePath);
             graphSpace.internalAlgorithmImageUrl(this.internalAlgorithmImageUrl);
-
-            graphSpace.configs(this.configs);
-
+            if (this.configs != null) {
+                graphSpace.configs(this.configs);
+            }
             return graphSpace;
         }
 
         public String toString() {
             return String.format("JsonGraphSpace{name=%s, description=%s, " +
                                  "cpuLimit=%s, memoryLimit=%s, " +
-                                 "storageLimit=%s, oltpNamespace=%s" +
-                                 "olapNamespace=%s, storageNamespace=%s" +
+                                 "storageLimit=%s, oltpNamespace=%s," +
+                                 "olapNamespace=%s, storageNamespace=%s," +
                                  "maxGraphNumber=%s, maxRoleNumber=%s, " +
                                  "configs=%s, operatorImagePath=%s, " +
                                  "internalAlgorithmImageUrl=%s}", this.name,

hugegraph-server/hugegraph-api/src/main/java/org/apache/hugegraph/config/ServerOptions.java

@@ -292,7 +292,7 @@ public class ServerOptions extends OptionHolder {
     public static final ConfigOption<String> SERVER_K8S_CA =
             new ConfigOption<>(
                     "server.k8s_ca",
-                    "The ca file of ks8 api server.",
+                    "The ca file of k8s api server.",
                     null,
                     ""
             );

pom.xml

@@ -87,8 +87,8 @@
 
     <properties>
         <fabric8.version>5.6.0</fabric8.version>
-        <revision>1.5.0</revision>
-        <hugegraph-commons.version>1.5.0</hugegraph-commons.version>
+        <revision>1.7.0</revision>
+        <hugegraph-commons.version>1.7.0</hugegraph-commons.version>
         <lombok.version>1.18.30</lombok.version>
         <release.name>hugegraph</release.name>
         <maven.compiler.source>11</maven.compiler.source>