Skip to content

Commit 01b4c8e

Browse files
committed
address feedback
1 parent a4af42f commit 01b4c8e

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

src/iceberg/manifest/manifest_reader.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -601,7 +601,7 @@ bool ManifestReader::ShouldDropStats(const std::vector<std::string>& columns) {
601601
// select record_count, which is a primitive type.
602602
if (!columns.empty()) {
603603
const std::unordered_set<std::string_view> selected(columns.cbegin(), columns.cend());
604-
if (selected.contains(ManifestReader::kAllColumns)) {
604+
if (selected.contains(Schema::kAllColumns)) {
605605
return false;
606606
}
607607
std::unordered_set<std::string_view> intersection;

src/iceberg/meson.build

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -167,6 +167,7 @@ install_headers(
167167
'arrow_c_data.h',
168168
'catalog.h',
169169
'constants.h',
170+
'delete_file_index.h',
170171
'exception.h',
171172
'file_format.h',
172173
'file_io.h',

src/iceberg/test/manifest_reader_test.cc

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -426,8 +426,7 @@ TEST_P(TestManifestReader, TestDropStats) {
426426

427427
TEST(ManifestReaderStaticTest, TestShouldDropStats) {
428428
EXPECT_FALSE(ManifestReader::ShouldDropStats({}));
429-
EXPECT_FALSE(
430-
ManifestReader::ShouldDropStats({std::string(ManifestReader::kAllColumns)}));
429+
EXPECT_FALSE(ManifestReader::ShouldDropStats({std::string(Schema::kAllColumns)}));
431430
EXPECT_TRUE(ManifestReader::ShouldDropStats({"file_path", "file_format", "partition"}));
432431
EXPECT_TRUE(
433432
ManifestReader::ShouldDropStats({"file_path", "file_format", "record_count"}));

0 commit comments

Comments
 (0)