Skip to content

Commit 0d3abb7

Browse files
committed
fix: cpp linter
1 parent 192f999 commit 0d3abb7

1 file changed

Lines changed: 12 additions & 14 deletions

File tree

src/iceberg/test/merge_append_test.cc

Lines changed: 12 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -347,18 +347,17 @@ class MergeAppendTestBase : public UpdateTestBase {
347347

348348
const ManifestFile* FindManifestByPath(const std::vector<ManifestFile>& manifests,
349349
const std::string& path) {
350-
auto it = std::find_if(
351-
manifests.begin(), manifests.end(),
352-
[&path](const ManifestFile& manifest) { return manifest.manifest_path == path; });
350+
auto it = std::ranges::find_if(manifests, [&path](const ManifestFile& manifest) {
351+
return manifest.manifest_path == path;
352+
});
353353
return it == manifests.end() ? nullptr : &*it;
354354
}
355355

356356
const ManifestFile* FindManifestForSpec(const std::vector<ManifestFile>& manifests,
357357
int32_t spec_id) {
358-
auto it = std::find_if(manifests.begin(), manifests.end(),
359-
[spec_id](const ManifestFile& manifest) {
360-
return manifest.partition_spec_id == spec_id;
361-
});
358+
auto it = std::ranges::find_if(manifests, [spec_id](const ManifestFile& manifest) {
359+
return manifest.partition_spec_id == spec_id;
360+
});
362361
return it == manifests.end() ? nullptr : &*it;
363362
}
364363

@@ -654,8 +653,8 @@ TEST_P(MergeAppendTest, EmptyTableAppendFilesAndManifest) {
654653
ExpectManifestEntries(*inherited_manifest, {file_a_, file_b_},
655654
{ManifestStatus::kAdded, ManifestStatus::kAdded});
656655

657-
auto appended_manifest = std::find_if(
658-
data_manifests.begin(), data_manifests.end(),
656+
auto appended_manifest = std::ranges::find_if(
657+
data_manifests,
659658
[&path](const ManifestFile& manifest) { return manifest.manifest_path != path; });
660659
ASSERT_NE(appended_manifest, data_manifests.end());
661660
ExpectManifestEntries(*appended_manifest, {file_c_, file_d_},
@@ -997,11 +996,10 @@ TEST_P(MergeAppendTest, MergeSizeTargetWithExistingManifest) {
997996
{first_snapshot->sequence_number, first_snapshot->sequence_number},
998997
{first_snapshot->sequence_number, first_snapshot->sequence_number});
999998

1000-
auto new_manifest =
1001-
std::find_if(data_manifests.begin(), data_manifests.end(),
1002-
[&initial_manifest](const ManifestFile& manifest) {
1003-
return manifest.manifest_path != initial_manifest.manifest_path;
1004-
});
999+
auto new_manifest = std::ranges::find_if(
1000+
data_manifests, [&initial_manifest](const ManifestFile& manifest) {
1001+
return manifest.manifest_path != initial_manifest.manifest_path;
1002+
});
10051003
ASSERT_NE(new_manifest, data_manifests.end());
10061004
ExpectManifestEntries(
10071005
*new_manifest, {file_c_, file_d_}, {ManifestStatus::kAdded, ManifestStatus::kAdded},

0 commit comments

Comments
 (0)