refactor: Initialize parquet_logical_type to nullptr and add empty metadata in WriteArray

Author: Joe-Abraham

src/iceberg/test/parquet_schema_test.cc

@@ -520,7 +520,7 @@ TEST(ParquetSchemaProjectionTest, ProjectPrimitiveType) {
   struct TestCase {
     std::shared_ptr<Type> iceberg_type;
     ::parquet::Type::type parquet_type;
-    std::shared_ptr<const ::parquet::LogicalType> parquet_logical_type;
+    std::shared_ptr<const ::parquet::LogicalType> parquet_logical_type = nullptr;
     int32_t primitive_length = -1;
   };
 
@@ -591,7 +591,7 @@ TEST(ParquetSchemaProjectionTest, UnsuportedProjection) {
   struct TestCase {
     std::shared_ptr<Type> iceberg_type;
     ::parquet::Type::type parquet_type;
-    std::shared_ptr<const ::parquet::LogicalType> parquet_logical_type;
+    std::shared_ptr<const ::parquet::LogicalType> parquet_logical_type = nullptr;
     int32_t primitive_length = -1;
   };
 

src/iceberg/test/parquet_test.cc

@@ -153,6 +153,7 @@ class ParquetReaderTest : public ::testing::Test {
     ASSERT_TRUE(WriteArray(array, {.path = temp_parquet_file_,
                                    .schema = schema,
                                    .io = file_io_,
+                                   .metadata = {},
                                    .properties = std::move(writer_properties)}));
   }
 
@@ -417,7 +418,11 @@ TEST_F(ParquetReadWrite, EmptyStruct) {
   std::shared_ptr<FileIO> file_io = arrow::ArrowFileSystemFileIO::MakeMockFileIO();
   const std::string basePath = "base.parquet";
 
-  ASSERT_THAT(WriteArray(array, {.path = basePath, .schema = schema, .io = file_io}),
+  ASSERT_THAT(WriteArray(array, {.path = basePath,
+                                 .schema = schema,
+                                 .io = file_io,
+                                 .metadata = {},
+                                 .properties = {}}),
               IsError(ErrorKind::kNotImplemented));
 }