temporarily fix issue with avro by disabling hidden visibility

HuaHuaY · HuaHuaY · commit 0fe89cb22f73 · 2025-12-19T22:59:29.000+08:00
diff --git a/cmake_modules/IcebergBuildUtils.cmake b/cmake_modules/IcebergBuildUtils.cmake
@@ -152,10 +152,6 @@ function(add_iceberg_lib LIB_NAME)
 
     string(TOUPPER ${LIB_NAME} VISIBILITY_NAME)
     target_compile_definitions(${LIB_NAME}_shared PRIVATE ${VISIBILITY_NAME}_EXPORTING)
-    set_target_properties(${LIB_NAME}_shared
-                          PROPERTIES C_VISIBILITY_PRESET hidden CXX_VISIBILITY_PRESET
-                                                                hidden
-                                     VISIBILITY_INLINES_HIDDEN 1)
 
     install(TARGETS ${LIB_NAME}_shared
             EXPORT iceberg_targets
diff --git a/src/iceberg/CMakeLists.txt b/src/iceberg/CMakeLists.txt
@@ -135,6 +135,13 @@ add_iceberg_lib(iceberg
                 OUTPUTS
                 ICEBERG_LIBRARIES)
 
+if(ICEBERG_BUILD_SHARED)
+  set_target_properties(iceberg_shared
+                        PROPERTIES C_VISIBILITY_PRESET hidden
+                                   CXX_VISIBILITY_PRESET hidden VISIBILITY_INLINES_HIDDEN
+                                                                1)
+endif()
+
 iceberg_install_all_headers(iceberg)
 
 add_subdirectory(catalog)
