Skip to content

Commit 23699bb

Browse files
committed
polish comments and logic to align with java
1 parent b93b4da commit 23699bb

13 files changed

Lines changed: 423 additions & 562 deletions

src/iceberg/table.cc

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,8 @@
3535
#include "iceberg/update/expire_snapshots.h"
3636
#include "iceberg/update/fast_append.h"
3737
#include "iceberg/update/merge_append.h"
38-
#include "iceberg/update/row_delta.h"
3938
#include "iceberg/update/overwrite_files.h"
39+
#include "iceberg/update/row_delta.h"
4040
#include "iceberg/update/set_snapshot.h"
4141
#include "iceberg/update/snapshot_manager.h"
4242
#include "iceberg/update/update_location.h"
@@ -356,6 +356,10 @@ Result<std::shared_ptr<RowDelta>> StaticTable::NewRowDelta() {
356356
return NotSupported("Cannot create a row delta for a static table");
357357
}
358358

359+
Result<std::shared_ptr<OverwriteFiles>> StaticTable::NewOverwrite() {
360+
return NotSupported("Cannot create an overwrite for a static table");
361+
}
362+
359363
Result<std::shared_ptr<SnapshotManager>> StaticTable::NewSnapshotManager() {
360364
return NotSupported("Cannot create a snapshot manager for a static table");
361365
}

src/iceberg/table.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -261,6 +261,8 @@ class ICEBERG_EXPORT StaticTable : public Table {
261261

262262
Result<std::shared_ptr<RowDelta>> NewRowDelta() override;
263263

264+
Result<std::shared_ptr<OverwriteFiles>> NewOverwrite() override;
265+
264266
Result<std::shared_ptr<SnapshotManager>> NewSnapshotManager() override;
265267

266268
private:

0 commit comments

Comments
 (0)