Skip to content

Commit 283ba61

Browse files
committed
refactor: initialize metadata fields in data writers
1 parent fc5b2fd commit 283ba61

3 files changed

Lines changed: 19 additions & 1 deletion

File tree

src/iceberg/data/data_writer.cc

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -93,8 +93,14 @@ class DataWriter::Impl {
9393
metrics.nan_value_counts.end()},
9494
.lower_bounds = std::move(lower_bounds_map),
9595
.upper_bounds = std::move(upper_bounds_map),
96+
.key_metadata = {},
9697
.split_offsets = std::move(split_offsets),
98+
.equality_ids = {},
9799
.sort_order_id = options_.sort_order_id,
100+
.first_row_id = std::nullopt,
101+
.referenced_data_file = std::nullopt,
102+
.content_offset = std::nullopt,
103+
.content_size_in_bytes = std::nullopt,
98104
.partition_spec_id =
99105
options_.spec ? std::make_optional(options_.spec->spec_id()) : std::nullopt,
100106
});

src/iceberg/data/equality_delete_writer.cc

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@ class EqualityDeleteWriter::Impl {
3535
.path = options.path,
3636
.schema = options.schema,
3737
.io = options.io,
38+
.metadata = {},
3839
.properties = WriterProperties::FromMap(options.properties),
3940
};
4041

@@ -92,9 +93,14 @@ class EqualityDeleteWriter::Impl {
9293
metrics.nan_value_counts.end()},
9394
.lower_bounds = std::move(lower_bounds_map),
9495
.upper_bounds = std::move(upper_bounds_map),
96+
.key_metadata = {},
9597
.split_offsets = std::move(split_offsets),
9698
.equality_ids = options_.equality_field_ids,
9799
.sort_order_id = options_.sort_order_id,
100+
.first_row_id = std::nullopt,
101+
.referenced_data_file = std::nullopt,
102+
.content_offset = std::nullopt,
103+
.content_size_in_bytes = std::nullopt,
98104
.partition_spec_id =
99105
options_.spec ? std::make_optional(options_.spec->spec_id()) : std::nullopt,
100106
});

src/iceberg/data/position_delete_writer.cc

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,7 @@ class PositionDeleteWriter::Impl {
4949
.path = options.path,
5050
.schema = delete_schema,
5151
.io = options.io,
52+
.metadata = {},
5253
.properties = WriterProperties::FromMap(options.properties),
5354
};
5455

@@ -152,9 +153,14 @@ class PositionDeleteWriter::Impl {
152153
metrics.nan_value_counts.end()},
153154
.lower_bounds = std::move(lower_bounds_map),
154155
.upper_bounds = std::move(upper_bounds_map),
156+
.key_metadata = {},
155157
.split_offsets = std::move(split_offsets),
156-
.sort_order_id = std::nullopt,
158+
.equality_ids = {},
159+
.sort_order_id = {},
160+
.first_row_id = std::nullopt,
157161
.referenced_data_file = std::move(referenced_data_file),
162+
.content_offset = std::nullopt,
163+
.content_size_in_bytes = std::nullopt,
158164
.partition_spec_id =
159165
options_.spec ? std::make_optional(options_.spec->spec_id()) : std::nullopt,
160166
});

0 commit comments

Comments
 (0)