feat: add tentative data & delete writer api (#463)

Co-authored-by: Gang Wu <ustcwg@gmail.com>

Author: shangxinli

src/iceberg/CMakeLists.txt

@@ -20,6 +20,9 @@ set(ICEBERG_INCLUDES "$<BUILD_INTERFACE:${PROJECT_BINARY_DIR}/src>"
 set(ICEBERG_SOURCES
     arrow_c_data_guard_internal.cc
     catalog/memory/in_memory_catalog.cc
+    data/data_writer.cc
+    data/equality_delete_writer.cc
+    data/position_delete_writer.cc
     data/writer.cc
     delete_file_index.cc
     expression/aggregate.cc

src/iceberg/data/data_writer.cc

@@ -0,0 +1,38 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+#include "iceberg/data/data_writer.h"
+
+namespace iceberg {
+
+class DataWriter::Impl {
+ public:
+};
+
+DataWriter::~DataWriter() = default;
+
+Status DataWriter::Write(ArrowArray* data) { return NotImplemented(""); }
+
+Result<int64_t> DataWriter::Length() const { return NotImplemented(""); }
+
+Status DataWriter::Close() { return NotImplemented(""); }
+
+Result<FileWriter::WriteResult> DataWriter::Metadata() { return NotImplemented(""); }
+
+}  // namespace iceberg

src/iceberg/data/data_writer.h

@@ -0,0 +1,68 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+#pragma once
+
+/// \file iceberg/data/data_writer.h
+/// Data writer for Iceberg tables.
+
+#include <cstdint>
+#include <memory>
+#include <optional>
+#include <string>
+#include <unordered_map>
+
+#include "iceberg/arrow_c_data.h"
+#include "iceberg/data/writer.h"
+#include "iceberg/file_format.h"
+#include "iceberg/iceberg_export.h"
+#include "iceberg/result.h"
+#include "iceberg/row/partition_values.h"
+#include "iceberg/type_fwd.h"
+
+namespace iceberg {
+
+/// \brief Options for creating a DataWriter.
+struct ICEBERG_EXPORT DataWriterOptions {
+  std::string path;
+  std::shared_ptr<Schema> schema;
+  std::shared_ptr<PartitionSpec> spec;
+  PartitionValues partition;
+  FileFormatType format = FileFormatType::kParquet;
+  std::shared_ptr<FileIO> io;
+  std::optional<int32_t> sort_order_id;
+  std::unordered_map<std::string, std::string> properties;
+};
+
+/// \brief Writer for Iceberg data files.
+class ICEBERG_EXPORT DataWriter : public FileWriter {
+ public:
+  ~DataWriter() override;
+
+  Status Write(ArrowArray* data) override;
+  Result<int64_t> Length() const override;
+  Status Close() override;
+  Result<WriteResult> Metadata() override;
+
+ private:
+  class Impl;
+  std::unique_ptr<Impl> impl_;
+};
+
+}  // namespace iceberg

src/iceberg/data/equality_delete_writer.cc

@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+#include "iceberg/data/equality_delete_writer.h"
+
+namespace iceberg {
+
+class EqualityDeleteWriter::Impl {
+ public:
+};
+
+EqualityDeleteWriter::~EqualityDeleteWriter() = default;
+
+Status EqualityDeleteWriter::Write(ArrowArray* data) { return NotImplemented(""); }
+
+Result<int64_t> EqualityDeleteWriter::Length() const { return NotImplemented(""); }
+
+Status EqualityDeleteWriter::Close() { return NotImplemented(""); }
+
+Result<FileWriter::WriteResult> EqualityDeleteWriter::Metadata() {
+  return NotImplemented("");
+}
+
+std::span<const int32_t> EqualityDeleteWriter::equality_field_ids() const { return {}; }
+
+}  // namespace iceberg

src/iceberg/data/equality_delete_writer.h

@@ -0,0 +1,72 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+#pragma once
+
+/// \file iceberg/data/equality_delete_writer.h
+/// Equality delete writer for Iceberg tables.
+
+#include <cstdint>
+#include <memory>
+#include <optional>
+#include <span>
+#include <string>
+#include <unordered_map>
+
+#include "iceberg/arrow_c_data.h"
+#include "iceberg/data/writer.h"
+#include "iceberg/file_format.h"
+#include "iceberg/iceberg_export.h"
+#include "iceberg/result.h"
+#include "iceberg/row/partition_values.h"
+#include "iceberg/type_fwd.h"
+
+namespace iceberg {
+
+/// \brief Options for creating an EqualityDeleteWriter.
+struct ICEBERG_EXPORT EqualityDeleteWriterOptions {
+  std::string path;
+  std::shared_ptr<Schema> schema;
+  std::shared_ptr<PartitionSpec> spec;
+  PartitionValues partition;
+  FileFormatType format = FileFormatType::kParquet;
+  std::shared_ptr<FileIO> io;
+  std::vector<int32_t> equality_field_ids;
+  std::optional<int32_t> sort_order_id;
+  std::unordered_map<std::string, std::string> properties;
+};
+
+/// \brief Writer for Iceberg equality delete files.
+class ICEBERG_EXPORT EqualityDeleteWriter : public FileWriter {
+ public:
+  ~EqualityDeleteWriter() override;
+
+  Status Write(ArrowArray* data) override;
+  Result<int64_t> Length() const override;
+  Status Close() override;
+  Result<WriteResult> Metadata() override;
+
+  std::span<const int32_t> equality_field_ids() const;
+
+ private:
+  class Impl;
+  std::unique_ptr<Impl> impl_;
+};
+
+}  // namespace iceberg

src/iceberg/data/position_delete_writer.cc

@@ -0,0 +1,44 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+#include "iceberg/data/position_delete_writer.h"
+
+namespace iceberg {
+
+class PositionDeleteWriter::Impl {
+ public:
+};
+
+PositionDeleteWriter::~PositionDeleteWriter() = default;
+
+Status PositionDeleteWriter::Write(ArrowArray* data) { return NotImplemented(""); }
+
+Status PositionDeleteWriter::WriteDelete(std::string_view file_path, int64_t pos) {
+  return NotImplemented("");
+}
+
+Result<int64_t> PositionDeleteWriter::Length() const { return NotImplemented(""); }
+
+Status PositionDeleteWriter::Close() { return NotImplemented(""); }
+
+Result<FileWriter::WriteResult> PositionDeleteWriter::Metadata() {
+  return NotImplemented("");
+}
+
+}  // namespace iceberg

src/iceberg/data/position_delete_writer.h

@@ -0,0 +1,69 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+#pragma once
+
+/// \file iceberg/data/position_delete_writer.h
+/// Position delete writer for Iceberg tables.
+
+#include <cstdint>
+#include <memory>
+#include <string>
+#include <string_view>
+#include <unordered_map>
+
+#include "iceberg/arrow_c_data.h"
+#include "iceberg/data/writer.h"
+#include "iceberg/file_format.h"
+#include "iceberg/iceberg_export.h"
+#include "iceberg/result.h"
+#include "iceberg/row/partition_values.h"
+#include "iceberg/type_fwd.h"
+
+namespace iceberg {
+
+/// \brief Options for creating a PositionDeleteWriter.
+struct ICEBERG_EXPORT PositionDeleteWriterOptions {
+  std::string path;
+  std::shared_ptr<Schema> schema;
+  std::shared_ptr<PartitionSpec> spec;
+  PartitionValues partition;
+  FileFormatType format = FileFormatType::kParquet;
+  std::shared_ptr<FileIO> io;
+  std::shared_ptr<Schema> row_schema;  // Optional row data schema
+  std::unordered_map<std::string, std::string> properties;
+};
+
+/// \brief Writer for Iceberg position delete files.
+class ICEBERG_EXPORT PositionDeleteWriter : public FileWriter {
+ public:
+  ~PositionDeleteWriter() override;
+
+  Status Write(ArrowArray* data) override;
+  Status WriteDelete(std::string_view file_path, int64_t pos);
+  Result<int64_t> Length() const override;
+  Status Close() override;
+  Result<WriteResult> Metadata() override;
+
+ private:
+  class Impl;
+  std::unique_ptr<Impl> impl_;
+};
+
+}  // namespace iceberg