fix: rename transaction location provider factory

Author: wgtmac

src/iceberg/transaction.cc

@@ -87,7 +87,8 @@ const TableMetadata& TransactionContext::current() const {
   return metadata_builder->current();
 }
 
-Result<std::unique_ptr<LocationProvider>> TransactionContext::LocationProvider() const {
+Result<std::unique_ptr<LocationProvider>> TransactionContext::NewLocationProvider()
+    const {
   return iceberg::LocationProvider::Make(current().location, current().properties);
 }
 

src/iceberg/transaction.h

@@ -188,7 +188,7 @@ class ICEBERG_EXPORT TransactionContext {
   const TableMetadata* base() const;
   const TableMetadata& current() const;
   std::string MetadataFileLocation(std::string_view filename) const;
-  Result<std::unique_ptr<LocationProvider>> LocationProvider() const;
+  Result<std::unique_ptr<LocationProvider>> NewLocationProvider() const;
 
   std::shared_ptr<Table> table;
   std::unique_ptr<TableMetadataBuilder> metadata_builder;

src/iceberg/update/merging_snapshot_update.cc

@@ -816,7 +816,7 @@ MergingSnapshotUpdate::MergeDVs() {
     return result;
   }
 
-  ICEBERG_ASSIGN_OR_RAISE(auto location_provider, ctx_->LocationProvider());
+  ICEBERG_ASSIGN_OR_RAISE(auto location_provider, ctx_->NewLocationProvider());
   auto output_path = location_provider->NewDataLocation(
       std::format("merged-dvs-{}-{}.puffin", SnapshotId(), ++dv_merge_attempt_));