Skip to content

Commit 3d1a92c

Browse files
author
shuxu.li
committed
feat: Implement NoopAuthManager and integrate AuthManager into RestCatalog
1 parent e94a1de commit 3d1a92c

2 files changed

Lines changed: 1 addition & 5 deletions

File tree

src/iceberg/catalog/rest/http_client.cc

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -68,8 +68,7 @@ namespace {
6868
/// \brief Default error type for unparseable REST responses.
6969
constexpr std::string_view kRestExceptionType = "RESTException";
7070

71-
/// \brief Build final request headers by merging request headers, default headers, and
72-
/// applying authentication.
71+
/// \brief Prepare headers for an HTTP request.
7372
Result<cpr::Header> BuildHeaders(
7473
const std::unordered_map<std::string, std::string>& request_headers,
7574
const std::unordered_map<std::string, std::string>& default_headers,

src/iceberg/catalog/rest/rest_catalog.cc

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,17 +26,14 @@
2626

2727
#include <nlohmann/json.hpp>
2828

29-
#include "iceberg/catalog/rest/auth/auth_manager.h"
3029
#include "iceberg/catalog/rest/auth/auth_managers.h"
31-
#include "iceberg/catalog/rest/auth/auth_session.h"
3230
#include "iceberg/catalog/rest/catalog_properties.h"
3331
#include "iceberg/catalog/rest/constant.h"
3432
#include "iceberg/catalog/rest/endpoint.h"
3533
#include "iceberg/catalog/rest/error_handlers.h"
3634
#include "iceberg/catalog/rest/http_client.h"
3735
#include "iceberg/catalog/rest/json_serde_internal.h"
3836
#include "iceberg/catalog/rest/resource_paths.h"
39-
#include "iceberg/catalog/rest/rest_catalog.h"
4037
#include "iceberg/catalog/rest/rest_util.h"
4138
#include "iceberg/catalog/rest/types.h"
4239
#include "iceberg/json_serde_internal.h"

0 commit comments

Comments
 (0)